From owner-svn-src-projects@FreeBSD.ORG Mon Jun 1 09:03:56 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 001881065670; Mon, 1 Jun 2009 09:03:55 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id E2B0B8FC0C; Mon, 1 Jun 2009 09:03:55 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n5193txg070680; Mon, 1 Jun 2009 09:03:55 GMT (envelope-from rwatson@svn.freebsd.org) Received: (from rwatson@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n5193tai070679; Mon, 1 Jun 2009 09:03:55 GMT (envelope-from rwatson@svn.freebsd.org) Message-Id: <200906010903.n5193tai070679@svn.freebsd.org> From: Robert Watson Date: Mon, 1 Jun 2009 09:03:55 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r193212 - projects/pnet/sys/net X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2009 09:03:56 -0000 Author: rwatson Date: Mon Jun 1 09:03:55 2009 New Revision: 193212 URL: http://svn.freebsd.org/changeset/base/193212 Log: Add missing VNET setup in the deferred dispatch case. Lock around stats updates in forced direct dispatch mode. Modified: projects/pnet/sys/net/netisr.c Modified: projects/pnet/sys/net/netisr.c ============================================================================== --- projects/pnet/sys/net/netisr.c Mon Jun 1 08:50:56 2009 (r193211) +++ projects/pnet/sys/net/netisr.c Mon Jun 1 09:03:55 2009 (r193212) @@ -77,6 +77,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #ifdef DDB #include @@ -697,7 +698,10 @@ netisr_process_workstream_proto(struct n if (local_npw.nw_head == NULL) local_npw.nw_tail = NULL; local_npw.nw_len--; + VNET_ASSERT(m->m_pkthdr.rcvif != NULL); + CURVNET_SET(m->m_pkthdr.rcvif->if_vnet); np[proto].np_handler(m); + CURVNET_RESTORE(); } KASSERT(local_npw.nw_len == 0, ("%s(%u): len %u", __func__, proto, local_npw.nw_len)); @@ -882,13 +886,17 @@ netisr_dispatch_src(u_int proto, uintptr /* * If direct dispatch is forced, then unconditionally dispatch * without a formal CPU selection. Borrow the current CPU's stats, - * even if there's no worker on it. + * even if there's no worker on it. In this case we don't update + * nws_flags because all netisr processing will be source ordered due + * to always being forced to directly dispatch. */ if (netisr_direct_force) { nwsp = &nws[curcpu]; npwp = &nwsp->nws_work[proto]; + NWS_LOCK(nwsp); npwp->nw_dispatched++; npwp->nw_handled++; + NWS_UNLOCK(nwsp); np[proto].np_handler(m); error = 0; goto out_unlock;