From owner-svn-src-all@FreeBSD.ORG Sat Jun 13 18:24:40 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DEE5CFE3 for ; Sat, 13 Jun 2015 18:24:40 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com [209.85.217.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 68633102 for ; Sat, 13 Jun 2015 18:24:39 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lbbqq2 with SMTP id qq2so34000300lbb.3 for ; Sat, 13 Jun 2015 11:24:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=r5RKYqxB3GJ0k0LSm/4+IN8u8aNPF8JUtxAcUfUBwKM=; b=SEZEDYUpm0u7BbUx8CVTZ+ajwMCSW/3wdxk47WBKL28PtwIUp6WLtiXgohQTWWIf0O jxm3Ak6MZi5AP5Uu8NAiLdwFxcHNtP8STOREfLtCDuA1jx/cWnDwbsRS6oUGQfF0kYCS QjubWsYyegdzOMivgiM+B+EISnUK1HQgHadfQu2vZBU1nKA9+r+dbwN8BaKyEmUHTguB etEMjmY/V4715cwQ5/FxxKJV9G7TgC0hS16ii1WM7ku5IHmt5ZojxZ2Yp5tB6bNBLSAG dViWarf5BVewcfaecNoLPfXcDbDDoGfknbGCciOw4LIVeQffJnEEzov6eV7UzRRVaHnR cgTQ== X-Gm-Message-State: ALoCoQkfVd+Eyexyxlu5ckDQNc1zZHwktJd9nLHlcey2sb+os3/hS0eHX0Sn9xJDhhHDTOcd9dKw X-Received: by 10.152.6.39 with SMTP id x7mr20103458lax.18.1434219877627; Sat, 13 Jun 2015 11:24:37 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id du2sm1547195lbc.44.2015.06.13.11.24.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Jun 2015 11:24:36 -0700 (PDT) From: Andrey Chernov Subject: Re: svn commit: r284198 - head/bin/ls To: Julian Elischer , Steve Kargl , Alexander Kabaev References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <557C3D9D.5050905@freebsd.org> Cc: Marcel Moolenaar , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <557C7562.4000809@freebsd.org> Date: Sat, 13 Jun 2015 21:24:34 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <557C3D9D.5050905@freebsd.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 18:24:41 -0000 On 13.06.2015 17:26, Julian Elischer wrote: > On 6/13/15 10:49 AM, Steve Kargl wrote: >> On Fri, Jun 12, 2015 at 08:43:09PM -0400, Alexander Kabaev wrote: >>> On Wed, 10 Jun 2015 01:27:39 +0000 (UTC) >>> Marcel Moolenaar wrote: >>> >>>> Author: marcel >>>> Date: Wed Jun 10 01:27:38 2015 >>>> New Revision: 284198 >>>> URL: https://svnweb.freebsd.org/changeset/base/284198 >>>> >>>> Log: >>>> Convert ls(1) to use libxo(3). >>>> Obtained from: Phil Shafer >>>> Sponsored by: Juniper Networks, Inc. >>>> >>> >>> >>> This broke all code that pipes output of the ls command to pipeline, >>> such as 'ls | wc -l'. ls never exits and never output anything. Is >>> there any purpose to libxo other than breaking stuff, which it achieves >>> so splendidly? >>> >> -1 for libxo, which also makes code almost unreadable. > +1 of the -1 > > my personal vote is to revert all libxo changes and banish it from > /usr/src. I already express my opinion in another thread, so just repeat it here. When libxo starts to break things at very early stage, I perceive the rest of the way to hell. "Proper way to do this thing is to back out all changes and write completely separate templates-based parser - xml/json/etc. writer." If somebody love libxo code, use it in that parser/writer. -- http://ache.vniz.net/ -- http://vniz.net/