From owner-freebsd-hackers@FreeBSD.ORG Thu Aug 28 13:57:42 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8FAA2408 for ; Thu, 28 Aug 2014 13:57:42 +0000 (UTC) Received: from mail-pa0-x22b.google.com (mail-pa0-x22b.google.com [IPv6:2607:f8b0:400e:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 619A6192A for ; Thu, 28 Aug 2014 13:57:42 +0000 (UTC) Received: by mail-pa0-f43.google.com with SMTP id et14so2707128pad.2 for ; Thu, 28 Aug 2014 06:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+834Sd35tShCNckwIQPT9ACU/Dl+6MaGMyHumcpp/yc=; b=Z3+vpi2pKbgzy2xRuYlyuOM10IeU/2Fzhvl2m4MLm/0GS8uny6bvrRbA1J+IKUkH4U PM6TMVrH10YBC9vmvnE0hKJVCpkMUx2bD6dxM07YW47nS9jJ+kzUlYSKK2MJsThkQ7x4 QpHoQfpygvbu5C8JbvRK3rnXkrW6TldTkZpeU/z9AV7dTMG81er4sC01tozojc1UPqT5 txKwmtXBf1GiXud5nNnGeqJjeF64c8D7iktZEtFgnyR8CQBoCJId7sbMaJXWu2RRZb/n IQ+Ef3FSzwTAJsJza6EzTaKumHhdv2Ve0FJuI7TTdd5lAgH9KBVcgREvv+Pb+oC4MuYc 0jkA== X-Received: by 10.68.241.138 with SMTP id wi10mr6152991pbc.126.1409234260401; Thu, 28 Aug 2014 06:57:40 -0700 (PDT) Received: from [127.0.0.1] ([202.55.17.37]) by mx.google.com with ESMTPSA id pn1sm3721535pbc.21.2014.08.28.06.57.37 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Aug 2014 06:57:39 -0700 (PDT) Content-Type: text/plain; charset="utf8"; Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: On changing rand(3) to random(3) in awk(1) X-Pgp-Agent: GPGMail (null) From: Chenguang Li In-Reply-To: <20140828133846.GB2385@straylight.m.ringlet.net> Date: Thu, 28 Aug 2014 21:57:24 +0800 Content-Transfer-Encoding: 8bit Message-Id: References: <53FEFBB8.5040305@gmail.com> <20140828131526.GA2385@straylight.m.ringlet.net> <5C40F611-22EB-49E4-8925-37922E771C0F@gmail.com> <20140828133846.GB2385@straylight.m.ringlet.net> To: Peter Pentchev X-Mailer: Apple Mail (2.1878.6) Cc: freebsd-hackers@freebsd.org, Vitaly Magerya X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 13:57:42 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Peter Pentchev wrote: >> ... ... >> [omitted] > > Right, but you've hard-coded RANDOM_MAX to 2^32-1. I don't think this > is correct; I do believe that you should use LONG_MAX for this value. > Of course, #define RANDOM_MAX LONG_MAX could be fine for this purpose > here, but the point is to use LONG_MAX instead of 2^32-1. I got your point, updated again. :) Chenguang Li -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJT/zVKAAoJELG4cS+11lRh7Q4P+wVrPEq6iLXZAgYCUYoaQcik DWLesOxLszjxr1nyx7kHD/vbBE04frhWbJZyBzmkmsLasXPckJxWpejpJGPwUGLX DpCyihobe94SUYwcXbnZ23Yv638dMGWWUptZuWkFe8L7CGUCF1nMwOpCh48U1t9E afDDxDdO8B6FOrAkCuqK5zEmC7yHGqLmG7p054MszG2wlnr8WVXK8xUho2GNccRM ykrpeFBIthzTQrM1UWX9IYmQSDD4nuUYwaL6wR0Jm/p0bhQzeZ01564I2FjkhZzz sKThSsFDjeNS49kQn30FnhbAn7+XfRd0DyWDl/Huaxvw63g4FbhkNUyiECKIiuyk A06Cr6pPeWJxRrsODacXdAhl8LCOQdrXo0XP/HXzT8a3TulCBxE/3v/s8WkJgPTd M8xQ5COtnJOW6GpYnq9cUF2KnelVrwb28N+6ThssRANNepMZ/dGljVoW1u2qBV+H cIn4wZFK++wo3skh4KS66RcfDkP083vsD+5SO742vBaobDxMXuU9jT4xytRW9twv GIl6c86aRhqUaa9FNgE2NGM4hDlyQgTO+I5npAo83JQGq93G5FikjYNA8SweqtrM PwnrIRhiVOMCvLW6Wr0eOUa2/c2WM+Zqb7B3Aoo8H1hAwN6C2SGpLhyY37Vja8Kd nFS/nlVdHpd2LDBV9+vH =gCzN -----END PGP SIGNATURE-----