Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Aug 2019 09:02:38 +0000 (UTC)
From:      Tobias Kortkamp <tobik@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r507940 - head/databases/pg_reorg
Message-ID:  <201908030902.x7392cKh061915@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tobik
Date: Sat Aug  3 09:02:38 2019
New Revision: 507940
URL: https://svnweb.freebsd.org/changeset/ports/507940

Log:
  databases/pg_reorg: Do not build on newer PostgreSQL versions
  
  It fails to build with PostgreSQL 11:
  
  pgut/pgut.c:389:47: error: too few arguments to function call, expected 4, have 3
          return simple_prompt("Password: ", 100, false);
                 ~~~~~~~~~~~~~                         ^
  /usr/local/include/postgresql/server/port.h:193:1: note: 'simple_prompt' declared here
  extern void simple_prompt(const char *prompt, char *destination, size_t destlen,
  ^
  1 error generated.
  
  http://package18.nyi.freebsd.org/data/120amd64-default-PR239514/2019-07-29_20h41m52s/logs/pg_reorg-1.1.11_2.log
  
  And after fixing that one:
  
  reorg.c:230:55: warning: incompatible pointer types passing 'bool [1]' to parameter of type 'const char *' [-Wincompatible-pointer-types]
                  execute_plan(SPI_OK_SELECT, plan_peek, values_peek, nulls_peek);
                                                                      ^~~~~~~~~~
  ./pgut/pgut-spi.h:28:84: note: passing argument to parameter 'nulls' here
  extern void execute_plan(int expected, SPIPlanPtr plan, Datum *values, const char *nulls);
                                                                                     ^
  reorg.c:256:58: warning: incompatible pointer types passing 'bool *' to parameter of type 'const char *' [-Wincompatible-pointer-types]
                                  execute_plan(SPI_OK_INSERT, plan_insert, &values[2], &nulls[2]);
                                                                                       ^~~~~~~~~
  [...]
  reorg.c:573:34: error: use of undeclared identifier 'BTREE_AM_OID'
                          opclass = OpclassnameGetOpcid(BTREE_AM_OID, opcname);
                                                        ^
  reorg.c:590:57: error: member reference type 'FormData_pg_attribute' (aka 'struct FormData_pg_attribute') is not a pointer; did you mean to use '.'?
                                  opcintype = RelationGetDescr(indexRel)->attrs[nattr]->atttypid;
                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
  etc.
  
  PR:		239514

Modified:
  head/databases/pg_reorg/Makefile

Modified: head/databases/pg_reorg/Makefile
==============================================================================
--- head/databases/pg_reorg/Makefile	Sat Aug  3 09:02:25 2019	(r507939)
+++ head/databases/pg_reorg/Makefile	Sat Aug  3 09:02:38 2019	(r507940)
@@ -24,8 +24,14 @@ PORTDOCS=	*
 
 OPTIONS_DEFINE=	DOCS
 
+.include <bsd.port.pre.mk>
+
+.if ${PGSQL_VER:R} >= 11
+IGNORE=	incompatible with PostgreSQL 11 or newer
+.endif
+
 post-install:
 	@${MKDIR} ${STAGEDIR}${DOCSDIR}
 	(cd ${WRKSRC}/doc && ${COPYTREE_SHARE} . ${STAGEDIR}${DOCSDIR})
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908030902.x7392cKh061915>