From owner-freebsd-toolchain@FreeBSD.ORG Tue Nov 13 02:26:35 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8C897A3B for ; Tue, 13 Nov 2012 02:26:35 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-ia0-f182.google.com (mail-ia0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 42B3C8FC12 for ; Tue, 13 Nov 2012 02:26:34 +0000 (UTC) Received: by mail-ia0-f182.google.com with SMTP id x2so403704iad.13 for ; Mon, 12 Nov 2012 18:26:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer :x-gm-message-state; bh=/fsNz9QzGgL7IowzDEq94UT4RAYeR2Y94LcDv5YDln4=; b=Ko8oJ0hRTRTIyhThuwuKvHLxqiMtN0mmWCqjk2oyIJB4efRf/4Yr89P4SWOfw/zkpy UQLwTFFP8uSu8aeWoqDLDwKPAGusoRMNRbAXUbe93486UBJxFu+j07ysHznfUJjdquha oAsHdHcpQBTlRgRv2YwrgeZrF6Re+jdupb5tpj/MdZuGkhu0V/AYY9d5G6obzUJOGoh3 HjgrbviaU2hdfzKPNtIlKI4btrW2QV2k6uZ/ibX56XhWSrdYqIdYm9NnQRFh/CPGrszc P2DP1k9UmFQxFUYQTPbJlyeXgYHJ6/D+0y++wfArbreLPYRtUNtm0NQVefqwils5A/tG 6ooQ== Received: by 10.50.207.104 with SMTP id lv8mr9805911igc.33.1352773594284; Mon, 12 Nov 2012 18:26:34 -0800 (PST) Received: from 53.imp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPS id uz12sm9627488igb.16.2012.11.12.18.26.32 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 12 Nov 2012 18:26:33 -0800 (PST) Sender: Warner Losh Subject: Re: arflags cleanup Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Mon, 12 Nov 2012 19:26:30 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <0693B91A-6320-4CE9-A6FA-821B290BB74C@bsdimp.com> References: <3D0FBCC4-743C-45B0-82E0-4C82501F7E60@cederstrand.dk> To: Erik Cederstrand X-Mailer: Apple Mail (2.1085) X-Gm-Message-State: ALoCoQmUwl/imkibwI7cKLsSX7Nt56CF2iwvq0sTfpEuvJxSyprJXJVnOS8F2qMeHooA9wZ9VrZz Cc: "toolchain@freebsd.org" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2012 02:26:35 -0000 On Nov 12, 2012, at 12:53 AM, Erik Cederstrand wrote: > Den 09/11/2012 kl. 16.22 skrev Erik Cederstrand : >=20 >> Den 09/11/2012 kl. 15.36 skrev Warner Losh : >>=20 >>> On Nov 9, 2012, at 3:52 AM, Erik Cederstrand wrote: >>>=20 >>>> Hello toolchainers, >>>>=20 >>>> I'm attempting to clean up hardcoded ar(1) flags in the tree to use = the global ARFLAGS in share/mk/sys.mk instead. I want to be able to add = "-D" to ARFLAGS and have it used everywhere. >>>>=20 >>>> The patch changes some hardcoded flags from e.g. "cru" to the = default "rl" or "rv" from sys.mk. Looking at the manpage for ar(1), I'm = pretty sure this is safe, and my runtime tests haven't turned out any = problems. Loosing the "u" flags means loosing a bit in performance in = theory, but I have tested this to be negligible in a buildworld / kernel = run. In a later iteration, maybe the default flags can be added a "u". >>>>=20 >>>> Are there any problems with this patch? >>>=20 >>> I don't like losing the 'c' flag. Makes things in the build too = whiny. >>> Why purposely lose the 'u' flag that you know helps performance? >>> Why move from cq to rl? This can be a big slow down... >>=20 >> I'd actually like to add both 'u' and 'c', I just didn't want to both = clean up and change the default in the same patch. A followup patch = could be: >=20 > If there are no other objections, I'll try to both patches into the = tree (I have no commit bit myself). You haven't answered my objections, so not yet. I haven't had a chance = to see if this message actually answers my concerns though (my life has = been busy). Warner=