From owner-freebsd-bugs@freebsd.org  Fri Aug 25 06:15:29 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 246D5DF07B4
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Fri, 25 Aug 2017 06:15:29 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0567174A2B
 for <freebsd-bugs@FreeBSD.org>; Fri, 25 Aug 2017 06:15:29 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v7P6FSB1029593
 for <freebsd-bugs@FreeBSD.org>; Fri, 25 Aug 2017 06:15:28 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 220698] [iflib][em] some interface options flags can not change
Date: Fri, 25 Aug 2017 06:15:27 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: kaho@elam.kais.kyoto-u.ac.jp
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.created
Message-ID: <bug-220698-8-QSQ8TigVtx@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-220698-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-220698-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Aug 2017 06:15:29 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220698

--- Comment #1 from Kaho Toshikazu <kaho@elam.kais.kyoto-u.ac.jp> ---
Created attachment 185741
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185741&action=
=3Dedit
make vlan_hwcsum and wol flags changeable

This patch makes only vlan_hwcsum and wol flags changeable.

1st chunk:
I think that IFCAP_FLAGS defines changeable flags in general.
In if.h, IFCAP_RXCSUM_IPV6 | IFCAP_TXCSUM_IPV6 is IFCAP_HWCSUM_IPV6,
and IFCAP_TSO4 | IFCAP_TSO6 is IFCAP_TSO. Change these flags for simplifyin=
g.
Add missing flags IFCAP_WOL_MCAST (contained by IFCAP_WOL) and
IFCAP_VLAN_HWCSUM.
IFCAP_HWSTATS should be removed because it is not changeable flags,
but it stays in the patch now.

2nd chunk:
Change from (IFCAP_TOE4 | IFCAP_TOE6) to IFCAP_TOE defined in if.h.
Delete WOL related lines. "setmask |=3D (mask & IFCAP_FLAGS);" has
same functionality, if IFCAP_FLAGS has IFCAP_WOL added by 1st chunk.

--=20
You are receiving this mail because:
You are the assignee for the bug.=