From owner-svn-src-head@FreeBSD.ORG  Mon Sep 16 19:37:49 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 8E982ECC;
 Mon, 16 Sep 2013 19:37:49 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6817427DA;
 Mon, 16 Sep 2013 19:37:49 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 69618B9B3;
 Mon, 16 Sep 2013 15:37:48 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Jean-Sebastien Pedron" <dumbbell@freebsd.org>
Subject: Re: svn commit: r255573 - head/sys/dev/drm2/radeon
Date: Mon, 16 Sep 2013 12:28:46 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; )
References: <201309141724.r8EHOgj8060898@svn.freebsd.org>
In-Reply-To: <201309141724.r8EHOgj8060898@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201309161228.46123.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Mon, 16 Sep 2013 15:37:48 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Sep 2013 19:37:49 -0000

On Saturday, September 14, 2013 1:24:42 pm Jean-Sebastien Pedron wrote:
> Author: dumbbell
> Date: Sat Sep 14 17:24:41 2013
> New Revision: 255573
> URL: http://svnweb.freebsd.org/changeset/base/255573
> 
> Log:
>   drm/radeon: Fix usage of pci_save_state() and pci_restore_state()
>   
>   Calling those functions with the drmn device as argument causes a panic,
>   because it's not a direct child of pci$N. They must be called with the
>   vgapci device instead.
>   
>   This fix is not enough to make suspend/resume work reliably.
>   
>   Approved by:	re (blanket)

Note that the PCI bus layer already does pci_save_state() during suspend
and pci_restore_state() during resume, so it is redundant for a driver to
do so.

-- 
John Baldwin