Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Oct 2022 15:04:35 +0200
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Kirill Ponomarev <krion@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 8177b0385384 - main - devel/pcre: Adding option to disable jit support
Message-ID:  <Y0/14yfUn7aoGHip@talos>
In-Reply-To: <202210190929.29J9Ta0X066965@gitrepo.freebsd.org>
References:  <202210190929.29J9Ta0X066965@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Qmip8X741ZXnqoF/
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Why enable JIT by default only on some architectures that work with it?
It should either be disabled on all by default, or enabled on all that
support it.

On 22-10-19 09:29:36, Kirill Ponomarev wrote:
> The branch main has been updated by krion:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D8177b0385384c4561e31c969=
8a1eb25ffdf720eb
>=20
> commit 8177b0385384c4561e31c9698a1eb25ffdf720eb
> Author:     Kirill Ponomarev <krion@FreeBSD.org>
> AuthorDate: 2022-10-19 09:28:44 +0000
> Commit:     Kirill Ponomarev <krion@FreeBSD.org>
> CommitDate: 2022-10-19 09:28:44 +0000
>=20
>     devel/pcre: Adding option to disable jit support
>    =20
>     PR:             267174
>     Reported by:    olivier
> ---
>  devel/pcre/Makefile | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>=20
> diff --git a/devel/pcre/Makefile b/devel/pcre/Makefile
> index fb9a2b63b98b..1bda6e50aef1 100644
> --- a/devel/pcre/Makefile
> +++ b/devel/pcre/Makefile
> @@ -1,6 +1,6 @@
>  PORTNAME=3D	pcre
>  PORTVERSION=3D	8.45
> -PORTREVISION=3D	1
> +PORTREVISION=3D	2
>  CATEGORIES=3D	devel
>  MASTER_SITES=3D	https://ftp.pcre.org/pub/pcre/ \
>  		SF
> @@ -31,16 +31,23 @@ TEST_TARGET=3D	check
> =20
>  PORTDOCS=3D	*
> =20
> -OPTIONS_DEFINE=3D		DOCS MAN3 STACK_RECURSION
> +OPTIONS_DEFINE=3D		DOCS JIT MAN3 STACK_RECURSION
>  OPTIONS_DEFAULT=3D	MAN3 STACK_RECURSION
> -OPTIONS_SUB=3D		yes
> +OPTIONS_DEFAULT_aarch64+=3D	JIT
> +OPTIONS_DEFAULT_amd64+=3D	JIT
> +OPTIONS_DEFAULT_i386+=3D	JIT
> +OPTIONS_DEFAULT_mips+=3D	JIT
> =20
>  OPTIONS_RADIO=3D		CLI
>  OPTIONS_RADIO_CLI=3D	LIBEDIT READLINE
> +OPTIONS_SUB=3D		yes
> =20
> +JIT_DESC=3D		Use the JIT compiler (not available on all platforms)
>  MAN3_DESC=3D		Install API manpages (section 3)
>  STACK_RECURSION_DESC=3D	Use the stack for recursion during matching
> =20
> +JIT_CONFIGURE_ENABLE=3D	jit
> +
>  LIBEDIT_USES=3D			libedit
>  LIBEDIT_CONFIGURE_ENABLE=3D	pcretest-libedit
> =20
> @@ -84,12 +91,6 @@ CONFIGURE_ARGS+=3D	--with-parens-nest-limit=3D${WITH_P=
ARENS_NEST_LIMIT}
>  CONFIGURE_ARGS+=3D	--with-posix-malloc-threshold=3D${WITH_POSIX_MALLOC_T=
HRESHOLD}
>  .endif
> =20
> -.if ${ARCH} !=3D "sparc64" && empty(ARCH:Mmips64*) && empty(ARCH:Mriscv6=
4*)
> -CONFIGURE_ARGS+=3D	--enable-jit
> -.else
> -CONFIGURE_ARGS+=3D	--disable-jit
> -.endif
> -
>  post-patch:
>  	@${REINPLACE_CMD} -e "/^\.rs/d" ${WRKSRC}/doc/*.3 ${WRKSRC}/doc/*.1
>  	@${REINPLACE_CMD} -e "s/=C2=A3//g" ${WRKSRC}/doc/pcre_compile2.3

--Qmip8X741ZXnqoF/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmNP9eMACgkQelmbhSCD
nJ2oJw//YgeNkg42yPsq+f3ISyyl6ETiGzgXwqpcXSl+D8fQ6jbBQFPpaz2k/4AL
H0GbGr8p+9/HyrRNgNJe89p2XDk216h96r1xZVr0FdyMGIt2kysbPd44frT3Lryg
ihvhYaDwxy4lkH0lHsBT3Lxdd7arKtqyBrTQmVjTPuhs93yXZYPodA4Wb8Ubb3Ri
KTyBbsmXWADabtRQPYcBWs3B/2bDPUgPgEZrXWNoTjdrbDSHzvTSek8D9Vo2/mni
33A23XkED2lrFXB8Vpj0zrynWqoSzSuIyoql0lGK9c6X4gSP03XLSGNRqLcXqoQ7
Sh9/96Y7aShNbEaCb2HdO2hbqwwYbWWOnVY4NiMO81z+NsRpjeD8Sy0HmEahUcLH
yBhSrgLTFXgvdMN5w5bQX0+45MSmg8iZOQfNmxjsDEaFmliZYzYXM3Hf5fWYYf/6
i3QyTy2DcIztgZqwfVlP42EmUV4rUmPka3cCHjc1aEx9jYFMsYRTGMt8RM2Innlh
ZSdhJl8DqFq+FBcMg7aLd98grcfi+61h/+O++TCPDsvnNzvAtW9Uf25D4vdHPcVc
OsctYAijcNx5agzqmetw7GdAPdtLFOghQ0k7aiC1yl1IbCAMN9/dHWrDIwcpHLdP
tUqq/TKubP7njL8bXdtTe8zTU7flBb2HYgxwaYdk2t5kXl/4vpA=
=PUD1
-----END PGP SIGNATURE-----

--Qmip8X741ZXnqoF/--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y0/14yfUn7aoGHip>