From owner-freebsd-fs@FreeBSD.ORG Wed Jul 17 19:46:05 2013 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A8030E47; Wed, 17 Jul 2013 19:46:05 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 0E2C07BC; Wed, 17 Jul 2013 19:46:04 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r6HJjvNV095405; Wed, 17 Jul 2013 22:45:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r6HJjvNV095405 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r6HJjvUH095403; Wed, 17 Jul 2013 22:45:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 17 Jul 2013 22:45:57 +0300 From: Konstantin Belousov To: Andriy Gapon Subject: Re: zfs_rename: another zfs+vfs deadlock Message-ID: <20130717194557.GU5991@kib.kiev.ua> References: <51E679FD.3040306@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/Isdj7O9hWi8F9Bn" Content-Disposition: inline In-Reply-To: <51E679FD.3040306@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-fs@FreeBSD.org, zfs-devel@FreeBSD.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2013 19:46:05 -0000 --/Isdj7O9hWi8F9Bn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2013 at 02:03:25PM +0300, Andriy Gapon wrote: > A scenario to reproduce this bug could be like this. > mkdir a > mkdir a/b > mv some-file a/b/ (in parallel with) stat a/b > Of course it would have to be repeated many times to hit the right timing > window. Also, namecache could interfere with this scenario, but I am not= sure. >=20 There is no questions or proposals on how to approach the fix, JFYI mail ? I recommend you to look at the ufs_checkpath() and its use in the ufs_rename(). --/Isdj7O9hWi8F9Bn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJR5vR0AAoJEJDCuSvBvK1BevYP/03MlbINCVbX1tI9KuT02IPF KK1YPWykvf11h/GmeONiZv3qZjvYWe9jwkga4f9Hrb6DjAhIZS+3MuIwLK12yANd xfNNFF7XMHcoxyvuF4wDeufgn04ttRgREV0vaDFnODL+fMhzuz7sfjXI4lM9x6+0 nZaAjsS8eR2rYgC2z0oPRyBK+/mMldayM5FWUXBynLpkjgwlk7XP7A6BX9Fw7Mtp vFVKtGSg613ugUYZWwgI5gzJbUjtGCO7l6gQyYQCDGBeetWmyPLRHfz2aS+KsPEI cpG5vi7ruXcA9KMUg8jW9M+9qyMcCKWsnkkTUcpUOXNhbpDMaRKthGM1MVSu8HA6 Q1KfdVuXWPYgg8GJvrBXo6UjgPQmzp/Gw2a4SE/DcHhZ4ouusU0lxX0TOErf+wHW 4i8vWCJO4zk7HIpX546wLqF7eOzDSGJ3VdCkWNheeO6ca7f8wAW8f2/8mD1iBdZo s3wcGSfAKcYXJMX5J7SwTtFtv8V36lU4+XxOo0KiW/tDTu07sPyo7Zgw6iRwnlr+ +KYJzqTI0RftjD0lKlJPYZJTSYIPYffzu9fweiyrO9BbzQf/k+amDK00k30oy1D9 zf0olSwJN+2FhfnzQJf9P+3Urq10JilpmH4xJwuy3M8yKtqQ/eLh4no2ojAORErl nr17M0hGUNV9MUHmaDwL =zpSb -----END PGP SIGNATURE----- --/Isdj7O9hWi8F9Bn--