From owner-dev-commits-src-all@freebsd.org  Mon Apr 26 19:00:56 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE4D25EC067;
 Mon, 26 Apr 2021 19:00:56 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FTZ3r3ZvRz4Scs;
 Mon, 26 Apr 2021 19:00:56 +0000 (UTC)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1])
 by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 13QJ0rBj099044;
 Mon, 26 Apr 2021 12:00:53 -0700 (PDT)
 (envelope-from freebsd@gndrsh.dnsmgr.net)
Received: (from freebsd@localhost)
 by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 13QJ0qHn099043;
 Mon, 26 Apr 2021 12:00:52 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Message-Id: <202104261900.13QJ0qHn099043@gndrsh.dnsmgr.net>
Subject: Re: git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in
 atomic_dec_and_lock_irqsave()
In-Reply-To: <CANCZdfpaa+VLmUtbyc6dVMrrAS7jAWDY-pNhj-Sg-Y7bNBn1vw@mail.gmail.com>
To: Warner Losh <imp@bsdimp.com>
Date: Mon, 26 Apr 2021 12:00:52 -0700 (PDT)
CC: Neel Chauhan <nc@freebsd.org>, John Baldwin <jhb@freebsd.org>,
 Shawn Webb <shawn.webb@hardenedbsd.org>,
 src-committers <src-committers@freebsd.org>,
 "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>,
 dev-commits-src-branches@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Rspamd-Queue-Id: 4FTZ3r3ZvRz4Scs
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2021 19:00:56 -0000

> On Mon, Apr 26, 2021 at 10:49 AM Neel Chauhan <nc@freebsd.org> wrote:
> 
> > On 2021-04-26 09:42, John Baldwin wrote:
> > > I agree.  20 minutes is far too short.  The normal minimum is 3 days.
> > > You already have feedback on the commits to main that you should
> > > probably adjust before merging (specifically Mateusz's quite salient
> > > point).
> > > Requiring two immediate fixups to the original commit in main is also
> > > indicative that the change in question isn't really ready yet.
> >
> > Sorry about this. I'm new(-ish?) to src.
> >
> > The immediate "fixups" are just formatting changes that were requested,
> > not really bugfixes.
> >
> 
> Only extremely urgent security-related or build-breakage-fixes are to be
> MFC'd faster than 3 days.
> At least that's been the rule we've articulated in the past. There's been
> some flexibility for things
> that are important, or when racing a release / snapshot schedule (eg a
> really good reason based
> on external factors)

Furthermore the original commit did infact state MFC: 3 days.  I was
shocked to see the immediate merge, but did flow to the end of the
thread before replying.

> Warner
-- 
Rod Grimes                                                 rgrimes@freebsd.org