Date: Mon, 26 Apr 2021 12:00:52 -0700 (PDT)
From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
To: Warner Losh <imp@bsdimp.com>
Cc: Neel Chauhan <nc@freebsd.org>, John Baldwin <jhb@freebsd.org>, Shawn Webb <shawn.webb@hardenedbsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-branches@freebsd.org
Subject: Re: git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()
Message-ID: <202104261900.13QJ0qHn099043@gndrsh.dnsmgr.net>
In-Reply-To: <CANCZdfpaa%2BVLmUtbyc6dVMrrAS7jAWDY-pNhj-Sg-Y7bNBn1vw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, Apr 26, 2021 at 10:49 AM Neel Chauhan <nc@freebsd.org> wrote: > > > On 2021-04-26 09:42, John Baldwin wrote: > > > I agree. 20 minutes is far too short. The normal minimum is 3 days. > > > You already have feedback on the commits to main that you should > > > probably adjust before merging (specifically Mateusz's quite salient > > > point). > > > Requiring two immediate fixups to the original commit in main is also > > > indicative that the change in question isn't really ready yet. > > > > Sorry about this. I'm new(-ish?) to src. > > > > The immediate "fixups" are just formatting changes that were requested, > > not really bugfixes. > > > > Only extremely urgent security-related or build-breakage-fixes are to be > MFC'd faster than 3 days. > At least that's been the rule we've articulated in the past. There's been > some flexibility for things > that are important, or when racing a release / snapshot schedule (eg a > really good reason based > on external factors) Furthermore the original commit did infact state MFC: 3 days. I was shocked to see the immediate merge, but did flow to the end of the thread before replying. > Warner -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202104261900.13QJ0qHn099043>