From owner-svn-ports-head@FreeBSD.ORG Thu Aug 21 22:13:03 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3FD9F70 for ; Thu, 21 Aug 2014 22:13:02 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A135A3D68 for ; Thu, 21 Aug 2014 22:13:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s7LMD2Ev076082 for ; Thu, 21 Aug 2014 22:13:02 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s7LMD2YJ076076 for svn-ports-head@freebsd.org; Thu, 21 Aug 2014 22:13:02 GMT (envelope-from bdrewery) Received: (qmail 67081 invoked from network); 21 Aug 2014 17:12:59 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 21 Aug 2014 17:12:59 -0500 Message-ID: <53F66EE5.7080500@FreeBSD.org> Date: Thu, 21 Aug 2014 17:12:53 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: marino@freebsd.org, freebsd.contact@marino.st Subject: Re: svn commit: r365590 - in head/cad/spice: . files References: <201408211941.s7LJf6de048334@svn.freebsd.org> <53F663B2.3000800@marino.st> <20140822.070939.1253386656808735449.hrs@allbsd.org> In-Reply-To: <20140822.070939.1253386656808735449.hrs@allbsd.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rHnn4q3oHTij2wCRfKRL9aUgJg28lEPSG" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Hiroki Sato , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2014 22:13:03 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rHnn4q3oHTij2wCRfKRL9aUgJg28lEPSG Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/21/2014 5:09 PM, Hiroki Sato wrote: > John Marino wrote > in <53F663B2.3000800@marino.st>: >=20 > fr> On 8/21/2014 21:41, Hiroki Sato wrote: > fr> > Author: hrs > fr> > Date: Thu Aug 21 19:41:06 2014 > fr> > New Revision: 365590 > fr> > URL: http://svnweb.freebsd.org/changeset/ports/365590 > fr> > QAT: https://qat.redports.org/buildarchive/r365590/ >=20 > ... >=20 > fr> I'm sorry, but using freebsd-specific in a ports vend= or > fr> makefile is NOT an improvement and frankly puts the build at risk o= n > fr> DragonFly. > fr> > fr> I wish there was a rule that ports should not use system make fragm= ents. > fr> This is not a good practice. This port had a perfectly working an= d > fr> generic makefile before. > fr> > fr> There's a good chance this just broke spice on DragonFly as the sys= tem > fr> make file these are different. >=20 > I can understand that vendor's Makefile should be platform-neutral, > but I do not think there is advantage to maintain > ${FILESDIR}/Makefile in a way not to use FreeBSD-specific stuff > because it is used only by the port. Should we care about build on > DragonFly? No! This is FreeBSD. Ports is only officially supported on FreeBSD. There are plenty of other ports using bsd.prog.mk. >=20 > -- Hiroki >=20 --=20 Regards, Bryan Drewery --rHnn4q3oHTij2wCRfKRL9aUgJg28lEPSG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJT9m7mAAoJEDXXcbtuRpfPAlwH/1ghr3/3aNoAO11JcvN38JZ6 apLnmQe2oop2WU/P7aX23JCym8+IHYHTJHz/J4FYKd/9PhTcSls0SYBKa7hC3P3D xilS7pWCDJ3fMVnYQCxbBEZwbrH4QNir2RvHBE3S8+OAztE20aIuZmjyHYmLNnxu Nir0QfYi9/hY9F9tyYPMjajc6LImOr8eRZpelc2jUwh3TkRREUKnOdD8TOkjd+mx kae0XMTDDNi7lXFTm+lNslfaAODsMLr7/v1JiHiJJFvUuwggRafHSumifXsunqHY aqeQlRz3rZEQmHKbU3O3RHshYHqSAE1YGTJ+CPp4qHnfFuO969pOXcuLMt93RCw= =i3Xd -----END PGP SIGNATURE----- --rHnn4q3oHTij2wCRfKRL9aUgJg28lEPSG--