From owner-svn-ports-all@FreeBSD.ORG Fri Jun 21 13:04:51 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id BC453AFD; Fri, 21 Jun 2013 13:04:51 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) by mx1.freebsd.org (Postfix) with ESMTP id 962F01EA7; Fri, 21 Jun 2013 13:04:51 +0000 (UTC) Received: from mail.adamw.org (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id E1AF711F9AA; Fri, 21 Jun 2013 08:55:19 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 21 Jun 2013 08:55:19 -0400 From: Adam Weinberger To: Alexey Dokuchaev Subject: Re: svn commit: r321445 - head/mail/gnarwl In-Reply-To: <20130621073819.GA1394@FreeBSD.org> References: <201306210619.r5L6JY12055282@svn.freebsd.org> <20130621073819.GA1394@FreeBSD.org> Message-ID: <3193101f9cd156d439cf8035bf174f3f@mail.adamw.org> X-Sender: adamw@adamw.org User-Agent: banemail fence Cc: svn-ports-head@freebsd.org, Antoine Brodin , owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Jason Helfman X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jun 2013 13:04:51 -0000 On 2013/06/21 03:38, Alexey Dokuchaev wrote: > On Thu, Jun 20, 2013 at 11:23:05PM -0700, Jason Helfman wrote: >> > -CONFIGURE_ARGS+=--with-docdir=${DOCSDIR} >> > +CONFIGURE_ARGS= --with-docdir=${DOCSDIR} >> >> It may look more pretty, but in the end your original commit didn't >> clobber >> any pre-existing CONFIGURE_ARGS that may have been set by the user. >> This >> one does. > > We never supported preset (users) CONFIGURE_ARGS, and it would be silly > thing if we did (contrary to CC/CFLAGS). There is an umpteen number of > configure scripts out there, both coming from different, often > incompatible > versions of autotools or written manually, and handling any > CONFIGURE_ARGS > in /etc/make.conf would likely break a lot of ports. User is not > supposed > to mess with them on that global level. > > It's maintainer's duty to ensure that port provides appropriate > configure > arguments; if user is smart/brave enough to change them, we must assume > that we knows what he's doing, and can edit Makefile directly. That > said, > CONFIGURE_ARGS= is correct here. As a smart and brave user, I prefer to be able to fiddle with things in /etc/make.conf, so that I don't have to re-patch the Makefile every time it gets updated. And sometimes, I even want to make customizations that aren't provided as an OPTION. A nice way to do that is .if ${.CURDIR:M*/mail/someport} CONFIGURE_ARGS+= --with-custom-banner=something .endif I understand your point, but if we're going to have a perspective, why not make it the perspective that lets users do as MUCH as possible, rather than limiting them to the subset of things that we pre-think for them? Our users are mighty smart folk; I propose giving them the benefit of the doubt. # Adam --- Adam Weinberger adamw@adamw.org http://www.adamw.org