From owner-svn-src-all@freebsd.org Sun Jul 29 19:18:39 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9ECA4105F8ED; Sun, 29 Jul 2018 19:18:39 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3368D712AC; Sun, 29 Jul 2018 19:18:39 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id BBC8A219E6; Sun, 29 Jul 2018 15:18:38 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute5.internal (MEProxy); Sun, 29 Jul 2018 15:18:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CIng86 wV/AGUR0I76m2sOvxN7l3UglvIxFikikTth40=; b=bt//Fx626ydt2ZZM4N+4UC Z8NwkQS1P1BANbhV7YS2xxen3NKjgw8PySJDkvtVaSYbJcuvdO+jnLadcN9E2Clp AwxALTE/ksAOtQLBa85f6h+fqJOzMYDZRWWpmgSg4XpHXmp8/PNN8116F2k0vwfM sVlPz+tbZcHCc2KZc1loHQhbtQBiDDAwA6bsUN+UTCCwAcc1C4EEthqAAms8Zc5M XX0OohXEMgfpCK2BilpSBPK4DDMneBRvIW1qOCoPHfNLSC8RVzLoeE085fBKoXs2 jN8qbEHw34wrxJPk2Fs+un9qK4sP31fg+TxuK0VvW1Y2bwhAYK7+DYWSh0nuCgmg == X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 54B624274; Sun, 29 Jul 2018 15:18:38 -0400 (EDT) Message-Id: <1532891918.1231266.1456630544.3F954111@webmail.messagingengine.com> From: Brad Davis To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-0843ff3e References: <201807282036.w6SKaNSi037944@repo.freebsd.org> <20180729154249.GG40119@kib.kiev.ua> <1532883687.1202573.1456550816.74531130@webmail.messagingengine.com> <20180729174447.GJ40119@kib.kiev.ua> <1532886692.1212563.1456581312.54C4C94B@webmail.messagingengine.com> <20180729183307.GK40119@kib.kiev.ua> In-Reply-To: <20180729183307.GK40119@kib.kiev.ua> Subject: Re: svn commit: r336845 - in head: etc etc/defaults etc/rc.d sbin/init sbin/init/rc.d Date: Sun, 29 Jul 2018 13:18:38 -0600 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 19:18:40 -0000 On Sun, Jul 29, 2018, at 12:33 PM, Konstantin Belousov wrote: > On Sun, Jul 29, 2018 at 11:51:32AM -0600, Brad Davis wrote: > > On Sun, Jul 29, 2018, at 11:44 AM, Konstantin Belousov wrote: > > > On Sun, Jul 29, 2018 at 11:01:27AM -0600, Brad Davis wrote: > > > > On Sun, Jul 29, 2018, at 9:42 AM, Konstantin Belousov wrote: > > > > > On Sat, Jul 28, 2018 at 08:36:23PM +0000, Brad Davis wrote: > > > > > > Author: brd > > > > > > Date: Sat Jul 28 20:36:23 2018 > > > > > > New Revision: 336845 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/336845 > > > > > > > > > > > > Log: > > > > > > Move rc startup scripts from etc/ to sbin/init/ > > > > > Why all these moves are useful ? > > > > > > > > > > No commit message explained what is the goal of the moves, and why > > > > > it is better that way comparing the existing src/etc collection. > > > > > > > > For pkg base we need to distill things out of etc/ and into places > > > > where they fit better. This enables them to be pkged up with the > > > > parts of the system them belong with and the CONFS= tags them as > > > > config files so that pkg will know about them and be able to 3-way > > > > merge them. This keeps the flexibility we have today with the many > > > > WITH_*/WITHOUT_* knobs. Though it is not without trade offs, keeping > > > > all of one part of the system together is simpler and makes some > > > > maintenance easier. > > > I do not see why do we need this for the pkgbase. There is nothing > > > wrong with installation of the whole clean dist-supplied /etc on > > > the fresh system. More, as you noted yourself, the ability to have > > > all the config files installed is simpler and allows to overview and > > > prepare configuration without requiring to have the corresponding > > > packages installed. > > > > On a fresh system sure, but on upgrades that is a problem. > > > > I was not advocating for having all the etc files installed, even when you do not have that pkg installed. I am saying it matches what happens today if you have, for example, WITHOUT_ACPI=y set. > > > All of this should have been written, perhaps even with more details, > in the commit message. You are right, I will working on improving my commit messages. Regards, Brad Davis