From owner-cvs-all Tue Jan 5 13:07:34 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA08263 for cvs-all-outgoing; Tue, 5 Jan 1999 13:07:34 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from jade.chc-chimes.com (jade.chc-chimes.com [206.67.97.83]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA08246; Tue, 5 Jan 1999 13:07:30 -0800 (PST) (envelope-from billf@jade.chc-chimes.com) Received: from localhost (billf@localhost) by jade.chc-chimes.com (8.8.8/8.8.8) with SMTP id QAA29831; Tue, 5 Jan 1999 16:07:57 -0500 (EST) (envelope-from billf@jade.chc-chimes.com) Date: Tue, 5 Jan 1999 16:07:57 -0500 (EST) From: Bill Fumerola To: John Birrell cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports@FreeBSD.ORG Subject: Re: cvs commit: ports/graphics/giftrans Makefile ports/graphics/mpeg2codec/patches patch-aa ports/graphics/splitmpg/patc In-Reply-To: <199901052102.IAA16286@cimlogic.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Wed, 6 Jan 1999, John Birrell wrote: > > This will prevent any future platform nits as well as keep people who roll > > there own packages and such happy. > > And use -O, not -O2, for both (particularly for alpha). I'm losing people here, or something. If it respects the systems CFLAGS, it shouldn't be changed using a patch at all... post-patch: ${MV} ${WRKSRC}/Makefile ${WRKSRC}/Makefile.old ${SED} -e 's#CFLAGS= -foo -m486 -bar#CFLAGS= ${CFLAGS}' \ ${WRKSRC}/Makefile.old > ${WRKSRC}/Makefile 90% of the CFLAGS bogons the live in our ports tree could be solved with those 5 easy lines of Makefile-ness. patch(1) is not the answer. - bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp - - ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org - To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message