From owner-freebsd-stable@FreeBSD.ORG  Thu Oct 23 01:43:08 2003
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6093D16A4B3
	for <freebsd-stable@freebsd.org>;
	Thu, 23 Oct 2003 01:43:08 -0700 (PDT)
Received: from serv.iaas.msu.ru (serv.iaas.msu.ru [212.192.224.252])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D704543FA3
	for <freebsd-stable@freebsd.org>;
	Thu, 23 Oct 2003 01:43:06 -0700 (PDT)
	(envelope-from master@iaas.msu.ru)
Received: from serv.iaas.msu.ru (serv.iaas.msu.ru [212.192.224.252])
	by serv.iaas.msu.ru (8.12.8p2/8.12.8) with ESMTP id h9N8h5uW025204;
	Thu, 23 Oct 2003 12:43:05 +0400 (MSD)
	(envelope-from master@iaas.msu.ru)
Date: Thu, 23 Oct 2003 12:43:05 +0400 (MSD)
From: Michail Vidiassov <master@iaas.msu.ru>
To: Doug White <dwhite@gumbysoft.com>
In-Reply-To: <20031022152527.W71676@carver.gumbysoft.com>
Message-ID: <20031023110929.I22874@serv.iaas.msu.ru>
References: <20031019005014.L49355@serv.iaas.msu.ru>
	<20031018161928.M35407@carver.gumbysoft.com>
	<20031022152527.W71676@carver.gumbysoft.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-stable@freebsd.org
Subject: Re: ACPI problem - broken debug output 
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Production branch of FreeBSD source code
	<freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2003 08:43:08 -0000

Dear Doug,


On Wed, 22 Oct 2003, Doug White wrote:

> > But after I have defined ACPI_DEBUG_OUTPUT in
> > /sys/contrib/dev/acpica/acconfig.h
> > I have got broken debug output like
> >
> > Table [DSDT] - %hd Objects with %hd Devices %hd Methods %hd Regions
> > %hd Devices found containing: %hd _STA, %hd _INI methods
> > Initialized %hd/%hd Regions %hd/%hd Fields %hd/%hd Buffers %hd/%hd
> > Packages (%hd nodes)
>
> Typically, acpi debugging is enabled using a couple of loader tunables, as
> described on acpi(4).  You just need to compile with ACPI_DEBUG to get the
> output functionality. I think ACPI_DEBUG_OUTPUT is some internal option
> that you shouldn't be messing with directly.
>

No, /sys/contrib/dev/acpica/CHANGES.txt told me:
Replace ACPI_DEBUG define with ACPI_DEBUG_OUTPUT.

The broken output is caused by the lack of support for
"h" (short int) optional character in the kvprintf
function, "Scaled down version of printf", residing in
/sys/kern/subr_prf.c

Thus the solution is to replace %hd with %d in
/sys/contirb/dev/acpica/* (since short is converted to
int anyway) or enhancing kvprintf to handle "h",
to make porting from Linux easier.

Is it worth sending a pr?

                    Sincerely, Michail
PS. BTW. acpi(4) does not mention the need to use
acpi_dsdt_type="acpi_dsdt", since it is a loader.conf
default on FreeBSD-CURRENT. But not on 4.9-??.
May be it is also worth reporting?
                Sincerely, Michail