From owner-svn-src-all@freebsd.org Mon Mar 11 09:26:43 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0304E153967A; Mon, 11 Mar 2019 09:26:43 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B1D08CC44; Mon, 11 Mar 2019 09:26:42 +0000 (UTC) (envelope-from andriyvos@gmail.com) Received: by mail-lj1-f176.google.com with SMTP id g80so3351690ljg.6; Mon, 11 Mar 2019 02:26:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=VFFhGcVt0+sWbJ40MExcq5AqzR4gUsxfdATRy+hcGA0=; b=T99MLnBnijlCApGugHwokAo+Xl3ecjVC1lYoU/UZpbCEcaRqmr1i35QFBcUWD2tp08 /RiTb0OCon9Zy69K3vyYmGZGf88Hk9ksvgp2hdCTk76BBWS6n7q2Ia4/fnaYe6C2C6uS NNFn62rpUibIhENrWv5yYJc2QKc8vS2UDErM6M/u9UOpnVjpcgmAphwKCODA7Xg8W2x1 pCdHq7R04u8PtWLGOEgeoS3ftv/XZmAlhl3toyYy0swF7XuIDWmOPtYH46w2fu58BE+o VE5OtLRIPlHHQyeoKeYqtMjjTShI/YFdZA1c+wyXajnwkeKkue/y2f8gAFPuDq1c5uxY f5Vg== X-Gm-Message-State: APjAAAXqvkh/hyXZecLJrqochCcP99564A/ScWPdWoycAHaQ7i/60t4d N0y+oh0DuK07gCcfsUfKdx4liDEVjDk= X-Google-Smtp-Source: APXvYqx+PSemDqJoT/GzwzLfvgUerTqpVSgL5QbkY1aH2C4RSysbete5dDvD3rUaEN4QgZSW0RvYEQ== X-Received: by 2002:a2e:968c:: with SMTP id q12mr153343lji.95.1552296395143; Mon, 11 Mar 2019 02:26:35 -0700 (PDT) Received: from localhost (46-133-145-217.dialup.umc.net.ua. [46.133.145.217]) by smtp.gmail.com with ESMTPSA id w17sm1124066lfk.18.2019.03.11.02.26.33 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Mar 2019 02:26:34 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Rodney W. Grimes" Cc: src-committers , svn-src-all , svn-src-head , "Warner Losh" Subject: Re: svn commit: r344990 - in head: share/man/man9 sys/dev/ath sys/dev/bwi sys/dev/bwn sys/dev/ipw sys/dev/iwi sys/dev/iwm sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/otus sys/dev/ral sys/dev/rtwn sys/... References: <201903110127.x2B1R2as090886@repo.freebsd.org> <5c85c429.1c69fb81.1869f.e87bSMTPIN_ADDED_BROKEN@mx.google.com> Date: Mon, 11 Mar 2019 11:25:41 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.15 (FreeBSD) X-Rspamd-Queue-Id: 5B1D08CC44 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.92)[-0.922,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 09:26:43 -0000 > > On Sun, Mar 10, 2019 at 8:12 PM Rodney W. Grimes > wrote: >>> Author: avos >> >>> Date: Mon Mar 11 01:27:01 2019 >> >>> New Revision: 344990 >> >>> URL: https://svnweb.freebsd.org/changeset/base/344990 >> >>> >> >>> Log: >> >>> Fix ieee80211_radiotap(9) usage in wireless drivers: >> >>> >> >>> - Alignment issues: >> >>> * Add missing __packed attributes + padding across all drivers; in >> >>> most places there was an assumption that padding will be always >> >>> minimally suitable; in few places - e.g., in urtw(4) / rtwn(4) - >> >>> padding was just missing. >> >>> * Add __aligned(8) attribute for all Rx radiotap headers since they >>> can >> >>> contain 64-bit TSF timestamp; it cannot appear in Tx radiotap >>> headers, so >> >>> just drop the attribute here. Refresh ieee80211_radiotap(9) man page >> >>> accordingly. >> >>> >> >>> - Since net80211 automatically updates channel frequency / flags in >> >>> ieee80211_radiotap_chan_change() drop duplicate setup for these >>> fields >> >>> in drivers. >> >>> >> >>> Tested with Netgear WG111 v3 (urtw(4)), STA mode. >> >>> >> >>> MFC after: 2 weeks >> >> >> >> Isnt this going to seriously break module load compatibility >> >> due to struct size and alignment changes if you merge this to stable/12? > > It looks like all these changes are within the modules, not in the > KBI... It looks like this will make things work >better on architectures > that don't like unaligned accesses. It seems like modules that aren't > updated don't work today >on those architectures... Yes, only drivers are touched - updated structures and driver's softc (where they are stored) are not exposed to other modules, so there is no need to keep size / offsets for structure members + the commit removes unaligned access, so urtw(4) (for example) will not work without this change on architectures, where unaligned access is prohibited. > > > Warner > >> >>> Modified: >> >>> head/share/man/man9/ieee80211_radiotap.9 >> >>> head/sys/dev/ath/if_athioctl.h >> >>> head/sys/dev/bwi/if_bwi.c >> >>> head/sys/dev/bwi/if_bwivar.h >> >>> head/sys/dev/bwn/if_bwn.c >> >>> head/sys/dev/bwn/if_bwnvar.h >> >> ... >> >> >> >> >> >> -- >> Rod Grimes >> rgrimes@freebsd.org >> >> >>