From owner-freebsd-ports@FreeBSD.ORG Tue May 26 08:48:36 2009 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 417791065678 for ; Tue, 26 May 2009 08:48:36 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from raven.customer.vol.cz (raven.customer.vol.cz [195.250.144.108]) by mx1.freebsd.org (Postfix) with ESMTP id 9E8708FC23 for ; Tue, 26 May 2009 08:48:35 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from [172.19.10.16] (nat-application.b1.lan.prg.vol.cz [195.122.204.152]) (authenticated bits=0) by raven.customer.vol.cz (8.14.3/8.14.3) with ESMTP id n4Q8mQUb039033; Tue, 26 May 2009 10:48:28 +0200 (CEST) (envelope-from pav@FreeBSD.org) From: Pav Lucistnik To: David Naylor In-Reply-To: <200905260819.23178.naylor.b.david@gmail.com> References: <200905251003.15408.naylor.b.david@gmail.com> <200905252247.32725.naylor.b.david@gmail.com> <20090526.111343.48515131.chat95@mac.com> <200905260819.23178.naylor.b.david@gmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-U9xTaKMfK9Pba8mOSn4J" Date: Tue, 26 May 2009 10:48:25 +0200 Message-Id: <1243327705.43470.8.camel@pav.hide.vol.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 FreeBSD GNOME Team Port X-Scanned-By: MIMEDefang 2.64 on 195.250.144.108 X-Milter: Spamilter (Reciever: raven.customer.vol.cz; Sender-ip: 195.122.204.152; Sender-helo: [172.19.10.16]; ) Cc: pgollucci@p6m7g8.com, itetcu@FreeBSD.org, freebsd-ports@FreeBSD.org Subject: Re: MAKE_JOBS_UNSAFE (some more ports) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2009 08:48:36 -0000 --=-U9xTaKMfK9Pba8mOSn4J Content-Type: text/plain; charset="ISO8859-2" Content-Transfer-Encoding: quoted-printable David Naylor p=ED=B9e v =FAt 26. 05. 2009 v 08:19 +0200: > pav: ${_MAKE_JOBS:C/-j//} won't work with DISABLE_MAKE_JOBS (or=20 > MAKE_JOBS_UNSAFE) since it needs to always be a positive number, secondly= it=20 > still cannot be used for conditional code (since it is defined in the pos= t=20 > section, but the whole code could always be moved to the pre section).=20 I'm hesitant to modify bsd.port.mk for benefit of just four ports. Also, I think having MAKE_JOBS_NUMBER set to 1 when the feature is in fact disable, is counter-intuitive (because -j1 is very different to no -j at all). So how about just having .if defined(DISABLE_MAKE_JOBS) MAKE_JOBS_NUMBER=3D 1 .else MAKE_JOBS_NUMBER!=3D echo `${SYSCTL} -n kern.smp.cpus` .endif in ooo makefile? --=20 Pav Lucistnik Go back to bed America, your government is in control again. Here's American Gladiators. Watch this, shut up. Here's 56 channels of it. Watch these pituitary retards bang their fuckin skulls together and congratulate you on living in the land of freedom. -- Bill Hicks --=-U9xTaKMfK9Pba8mOSn4J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkobrNkACgkQntdYP8FOsoL7IQCgqXO9ivAkGBIOJajNG9hGTz3b qOwAnA+p0VfD8CBs1ktwPDpneSkKz0PI =x0Gs -----END PGP SIGNATURE----- --=-U9xTaKMfK9Pba8mOSn4J--