From owner-svn-src-head@freebsd.org  Mon Jan 22 07:48:38 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 104C9ED4365;
 Mon, 22 Jan 2018 07:48:38 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id E604D70189;
 Mon, 22 Jan 2018 07:48:37 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 430F161BF; Mon, 22 Jan 2018 07:48:37 +0000 (UTC)
Date: Mon, 22 Jan 2018 07:48:37 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Poul-Henning Kamp <phk@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r328259 - in head: share/man/man4
 sys/arm/broadcom/bcm2835
Message-ID: <20180122074837.GA39396@FreeBSD.org>
References: <201801220743.w0M7hspG008170@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201801220743.w0M7hspG008170@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 07:48:38 -0000

On Mon, Jan 22, 2018 at 07:43:54AM +0000, Poul-Henning Kamp wrote:
> New Revision: 328259
> URL: https://svnweb.freebsd.org/changeset/base/328259
> 
> Log:
>   Add skeleton manual page for bcm283x_pwm
>   
>   (Feel free to improve this)
> 
> Added:
>   head/share/man/man4/bcm283x_pwm.4   (contents, props changed)
> Modified:
>   head/share/man/man4/Makefile
>   head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c
> 
> ...
> Modified: head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c
> ==============================================================================
> --- head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c	Mon Jan 22 07:15:24 2018	(r328258)
> +++ head/sys/arm/broadcom/bcm2835/bcm2835_clkman.c	Mon Jan 22 07:43:54 2018	(r328259)
> @@ -150,13 +150,13 @@ bcm2835_clkman_set_frequency(device_t dev, uint32_t un
>  	u = 500000000/hz;
>  	if (u < 4) {
>  		device_printf(sc->sc_dev,
> -		    "Frequency too high for unit 0x%x (max: 125MHz)",
> +		    "Frequency too high for unit 0x%x (max: 125 MHz)",
>  		    unit);
>  		return (0);
>  	}
>  	if (u > 0xfff) {
>  		device_printf(sc->sc_dev,
> -		    "Frequency too low for unit 0x%x (min: 123Hz)",
> +		    "Frequency too low for unit 0x%x (min: 123 kHz)",
>  		    unit);

These changes look unrelated to the manual page.  Is this intended?
On a related note, this code contains a number of style bugs, you might
want to do a quick sweep on fixing them.

./danfe