From owner-p4-projects@FreeBSD.ORG  Tue Dec  2 18:47:37 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 14DC216A4D0; Tue,  2 Dec 2003 18:47:37 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DF1FC16A4CE
	for <perforce@freebsd.org>; Tue,  2 Dec 2003 18:47:36 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 24B5F43FE9
	for <perforce@freebsd.org>; Tue,  2 Dec 2003 18:47:36 -0800 (PST)
	(envelope-from peter@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id hB32lZXJ096546
	for <perforce@freebsd.org>; Tue, 2 Dec 2003 18:47:35 -0800 (PST)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.9/8.12.9/Submit) id hB32lZu0096543
	for perforce@freebsd.org; Tue, 2 Dec 2003 18:47:35 -0800 (PST)
	(envelope-from peter@freebsd.org)
Date: Tue, 2 Dec 2003 18:47:35 -0800 (PST)
Message-Id: <200312030247.hB32lZu0096543@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 43344 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Dec 2003 02:47:37 -0000

http://perforce.freebsd.org/chv.cgi?CH=43344

Change 43344 by peter@peter_overcee on 2003/12/02 18:47:17

	capture this before I lose it too.  Add -E (elapsed) time stamps.
	This is IMHO more useful than both -R and/or -T.

Affected files ...

.. //depot/projects/hammer/usr.bin/kdump/kdump.1#3 edit
.. //depot/projects/hammer/usr.bin/kdump/kdump.c#6 edit

Differences ...

==== //depot/projects/hammer/usr.bin/kdump/kdump.1#3 (text+ko) ====

@@ -40,7 +40,7 @@
 .Nd display kernel trace data
 .Sh SYNOPSIS
 .Nm
-.Op Fl dnlRT
+.Op Fl dnlERT
 .Op Fl f Ar file
 .Op Fl m Ar maxdata
 .Op Fl p Ar pid
@@ -89,6 +89,8 @@
 .Ar pid .
 This may be useful when there are multiple processes recorded in the
 same trace file.
+.It Fl E
+Display elapsed timestamps (time since beginning of trace).
 .It Fl R
 Display relative timestamps (time since previous entry).
 .It Fl T

==== //depot/projects/hammer/usr.bin/kdump/kdump.c#6 (text+ko) ====

@@ -97,7 +97,7 @@
 
 	(void) setlocale(LC_CTYPE, "");
 
-	while ((ch = getopt(argc,argv,"f:dlm:np:RTt:")) != -1)
+	while ((ch = getopt(argc,argv,"f:dlm:np:ERTt:")) != -1)
 		switch((char)ch) {
 		case 'f':
 			tracefile = optarg;
@@ -117,6 +117,9 @@
 		case 'p':
 			pid = atoi(optarg);
 			break;
+		case 'E':
+			timestamp = 3;	/* elapsed timestamp */
+			break;
 		case 'R':
 			timestamp = 2;	/* relative timestamp */
 			break;
@@ -249,6 +252,11 @@
 
 	(void)printf("%6d %-8.*s ", kth->ktr_pid, MAXCOMLEN, kth->ktr_comm);
 	if (timestamp) {
+		if (timestamp == 3) {
+			if (prevtime.tv_sec == 0)
+				prevtime = kth->ktr_time;
+			timevalsub(&kth->ktr_time, &prevtime);
+		}
 		if (timestamp == 2) {
 			temp = kth->ktr_time;
 			timevalsub(&kth->ktr_time, &prevtime);