From owner-freebsd-current@FreeBSD.ORG Tue Oct 11 17:46:11 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7928A106564A for ; Tue, 11 Oct 2011 17:46:11 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from mx0.hoeg.nl (mx0.hoeg.nl [IPv6:2a01:4f8:101:5343::aa]) by mx1.freebsd.org (Postfix) with ESMTP id 1452F8FC0A for ; Tue, 11 Oct 2011 17:46:11 +0000 (UTC) Received: by mx0.hoeg.nl (Postfix, from userid 1000) id 403922A28CCA; Tue, 11 Oct 2011 19:46:10 +0200 (CEST) Date: Tue, 11 Oct 2011 19:46:10 +0200 From: Ed Schouten To: poyopoyo@puripuri.plala.or.jp Message-ID: <20111011174610.GV91943@hoeg.nl> References: <86sjmzra73.wl%poyopoyo@puripuri.plala.or.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6tnUusbJa3r4kWvc" Content-Disposition: inline In-Reply-To: <86sjmzra73.wl%poyopoyo@puripuri.plala.or.jp> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-current@FreeBSD.org Subject: Re: MPSAFE tty and lastcomm output X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2011 17:46:11 -0000 --6tnUusbJa3r4kWvc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi , * poyopoyo@puripuri.plala.or.jp , 20111011 1= 4:20: > It looks stored accounting information is correct, but lastcomm failed > to represent device name gently after it has been destroyed. Yes, exactly. Our struct acct uses a dev_t to store the controlling TTY. This is obviously completely broken on 8+, because we garbage collect pseudo-terminals. Still, one could argue it has always been broken, because even before the new TTY layer it would break when unplugging USB-to-serial converters or performing a reboot. I think the only way to fix this, is by updating the acct structure to write a string representation of the device name. Best regards, --=20 Ed Schouten WWW: http://80386.nl/ --6tnUusbJa3r4kWvc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iQIcBAEBAgAGBQJOlIDiAAoJEG5e2P40kaK7Jb4P/R5FdFlNJIcC0RkzDF9/IVpf 8SLNVOdpHpySP0OyhChcuaKnTfTwDUMJ4G6yUZlu0FvZIx8NrkZgKZqjvioTgxVD 48lmk3TqdATU9r/MmWRpxsLYf6w+PesOAYPn494g4urmBhukiwDPNOOGtlzA4SWH cZUfCqXGXUD98CrADPY1B5hpQGaY2oLhUxy5hZPc98k1opmgq9sw+AyUyggJvOao B4xN8Lg16K6HOGndrhnXBbQu9tTPo8YTy0meGJh/NtkzDomVeVyks7i3xIHgn4xW p1dpZzRQCePKZPkMzIZebwfoU8kQ/qCCJXBdVrR7/FgjFjLOdSNfg/p0J7+c5LsU oa0C6xE489q1j5aypZb6oC41/WzPJD2dGIBfFsKKt1kWhPuoTZTXsxcWhNlo2mL1 qIg8DBKhTtStMN+aMvfhCZSZTXBpPnel/DgOgyuPM/NojCygPVZzd7ZLLmuNdlOz GrzHxFctcjW9DSAHcKP5oVx8Pke3wBV/CQC8q9dvtNMmuW/qQuadIp5Esm3UDSNx dWCgUzvKBpe701WWTWIqFEC1yfzLaRyLN+yG/69Fastx5nC+foz/9g/sHMbM5F1l pNywWWcD+xWwhgK5stHgyYV+QVz4LxwGR0MzP/hy+7Z77eLv9JTPILnoKB4RdAAi kofxGZlCcHMt2BWnwzct =LlSU -----END PGP SIGNATURE----- --6tnUusbJa3r4kWvc--