From owner-svn-ports-all@FreeBSD.ORG  Sun Mar 29 16:53:19 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 9C8F6BF0;
 Sun, 29 Mar 2015 16:53:19 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7139AADA;
 Sun, 29 Mar 2015 16:53:18 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 5F46843BC8;
 Sun, 29 Mar 2015 11:53:09 -0500 (CDT)
Message-ID: <55182DED.3020209@marino.st>
Date: Sun, 29 Mar 2015 18:53:01 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org, 
 ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r382595 - head/net/hostapd
References: <201503291215.t2TCFfpV085298@svn.freebsd.org>
 <FC0C9C741284BFF1D1E45566@atuin.in.mat.cc> <5517F013.6090403@marino.st>
 <95DE044D7600DE3AD898D6A6@atuin.in.mat.cc>
In-Reply-To: <95DE044D7600DE3AD898D6A6@atuin.in.mat.cc>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Mar 2015 16:53:19 -0000

On 3/29/2015 19:44, Mathieu Arnold wrote:
> 
> 
> +--On 29 mars 2015 14:29:07 +0200 John Marino <freebsd.contact@marino.st>
> wrote:
> | On 3/29/2015 15:20, Mathieu Arnold wrote:
> |> +--On 29 mars 2015 12:15:41 +0000 John Marino <marino@FreeBSD.org> wrote:
> |> | +OPTIONS_DEFINE=	PORTS_SSL
> |> | +
> |> | +PORTS_SSL_DESC= Build with OpenSSL from ports (instead of base system)
> |> | +
> |> | +.include <bsd.port.options.mk>
> |> | +
> |> | +.if ${PORT_OPTIONS:MPORTS_SSL}
> |> | +.if !defined(WITH_OPENSSL_PORT)
> |> | +IGNORE=		the PORTS_SSL option not allowed when WITH_OPENSSL_PORT is
> |> | not set +.endif
> |> | +CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX}
> |> | +.else
> |> | +.if defined(WITH_OPENSSL_PORT)
> |> | +IGNORE=		the PORTS_SSL option is required when WITH_OPENSSL_PORT is
> |> | set +.endif
> |> | +.endif
> |> 
> |> That seems way overly complicated, why not just do:
> |> 
> |> .if defined(WITH_OPENSSL_PORT)
> |> CONFIGURE_ARGS+= --with-ssl-dir=${PREFIX}
> |> .endif
> | 
> | 
> | I assume the maintainer wants to preserve the possibility to not include
> | openssl capability at all...  (neither port nor base)
> 
> Mmmm, well, no, the only thing what you committed does is force the one
> building the port is to say that he's using, or not, OpenSSL from ports,
> and have it broken if one choose wrong.
> 

I passed the suggestion to the maintainer via the PR.
John