From owner-svn-ports-all@freebsd.org  Sat May 21 18:35:07 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1AE2B44247;
 Sat, 21 May 2016 18:35:07 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 9F80D11AE;
 Sat, 21 May 2016 18:35:07 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 9DF6F1591; Sat, 21 May 2016 18:35:07 +0000 (UTC)
Date: Sat, 21 May 2016 18:35:07 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Cc: Baptiste Daroussin <bapt@freebsd.org>, marino@freebsd.org,
 Ed Maste <emaste@freebsd.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r415078 - in head: . Mk
Message-ID: <20160521183507.GB96389@FreeBSD.org>
References: <20160513182837.GF49383@ivaldir.etoilebsd.net>
 <20160513201919.GA48945@FreeBSD.org>
 <CAPyFy2A9L1cCikOrgBAWUo0GTCLJ4EgzqukhobaJp+Zqv7_SpQ@mail.gmail.com>
 <20160519122306.GA24015@FreeBSD.org>
 <20160521112728.GA624@FreeBSD.org>
 <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st>
 <20160521114358.GC624@FreeBSD.org>
 <20160521122522.GJ21899@ivaldir.etoilebsd.net>
 <20160521162931.GA97771@FreeBSD.org>
 <43145C09-EC33-4738-9FE7-5DC34A74D64B@adamw.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43145C09-EC33-4738-9FE7-5DC34A74D64B@adamw.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 May 2016 18:35:07 -0000

On Sat, May 21, 2016 at 11:11:12AM -0600, Adam Weinberger wrote:
> > On 21 May, 2016, at 10:29, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > On Sat, May 21, 2016 at 02:25:22PM +0200, Baptiste Daroussin wrote:
> >> Implementing it as a Makefile variable would make it not automatically
> >> updated.
> > 
> > Even if we can agree on REP_TIMESTAMP variable, why `make makesum' cannot
> > sed -i the Makefile?
> 
> Oh god, please, no. Please do not mess with Makefiles.
> 
> Rather than having it come from 'makesum', can an svn hook write it to
> distinfo? May help it stay more current.

I understand your worries, but SVN already messes with Makefiles (keywords).
On the other hand, adding $Id$ to distinfo would both 1) solve the problem,
at least as I see it now, and 2) won't mix data with metadata which is I'm
debating against.

Baptiste, was adding $Id$ to distinfo considered/tested?  If yes, why was it
rejected?

./danfe