From owner-svn-src-all@FreeBSD.ORG  Mon May 11 18:45:04 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C9300106566C;
	Mon, 11 May 2009 18:45:04 +0000 (UTC)
	(envelope-from rmacklem@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id B743A8FC12;
	Mon, 11 May 2009 18:45:04 +0000 (UTC)
	(envelope-from rmacklem@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4BIj4JN099123;
	Mon, 11 May 2009 18:45:04 GMT
	(envelope-from rmacklem@svn.freebsd.org)
Received: (from rmacklem@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4BIj4gV099122;
	Mon, 11 May 2009 18:45:04 GMT
	(envelope-from rmacklem@svn.freebsd.org)
Message-Id: <200905111845.n4BIj4gV099122@svn.freebsd.org>
From: Rick Macklem <rmacklem@FreeBSD.org>
Date: Mon, 11 May 2009 18:45:04 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r191998 - head/sys/fs/nfsserver
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 May 2009 18:45:05 -0000

Author: rmacklem
Date: Mon May 11 18:45:04 2009
New Revision: 191998
URL: http://svn.freebsd.org/changeset/base/191998

Log:
  	Modify nfsvno_fhtovp() to ensure that it always sets the credp
  	argument. Returning without credp set could result in a caller
  	doing crfree() on garbage.
  
  Reviewed by:	kan
  Approved by:	kib (mentor)

Modified:
  head/sys/fs/nfsserver/nfs_nfsdport.c

Modified: head/sys/fs/nfsserver/nfs_nfsdport.c
==============================================================================
--- head/sys/fs/nfsserver/nfs_nfsdport.c	Mon May 11 18:20:34 2009	(r191997)
+++ head/sys/fs/nfsserver/nfs_nfsdport.c	Mon May 11 18:45:04 2009	(r191998)
@@ -2422,6 +2422,7 @@ nfsvno_fhtovp(struct mount *mp, fhandle_
 	int error;
 	int numsecflavor, *secflavors;
 
+	*credp = NULL;
 	error = VFS_FHTOVP(mp, &fhp->fh_fid, vpp);
 	if (nam && !error) {
 		error = VFS_CHECKEXP(mp, nam, &exp->nes_exflag, credp,