From owner-freebsd-net@FreeBSD.ORG  Fri Sep 22 07:45:20 2006
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 859B016A4D1
	for <freebsd-net@freebsd.org>; Fri, 22 Sep 2006 07:45:20 +0000 (UTC)
	(envelope-from Sivakumar.Subramani@neterion.com)
Received: from barracuda.s2io.com (barracuda.s2io.com [72.1.205.138])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F1DDA43D5F
	for <freebsd-net@freebsd.org>; Fri, 22 Sep 2006 07:45:19 +0000 (GMT)
	(envelope-from Sivakumar.Subramani@neterion.com)
X-ASG-Debug-ID: 1158911118-30368-11-2
X-Barracuda-URL: http://72.1.205.138:8000/cgi-bin/mark.cgi
X-ASG-Whitelist: Client
Received: from owa.neterion.com (unknown [72.1.205.142])
	by barracuda.s2io.com (Spam Firewall) with ESMTP id 823512018122
	for <freebsd-net@freebsd.org>; Fri, 22 Sep 2006 03:45:18 -0400 (EDT)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
X-ASG-Orig-Subj: Absolute path inclusion in the FreeBSD Drivers.
Date: Fri, 22 Sep 2006 03:45:14 -0400
Message-ID: <78C9135A3D2ECE4B8162EBDCE82CAD77C8928C@nekter>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: Absolute path inclusion in the FreeBSD Drivers.
Thread-Index: AcbeGwmMmkKrdn63QJqT6Jj/cnDzQA==
From: "Sivakumar Subramani" <Sivakumar.Subramani@neterion.com>
To: <freebsd-net@freebsd.org>
X-Virus-Scanned: by Barracuda Spam Firewall at s2io.com
X-Barracuda-Spam-Score: 0.00
X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=3.5
	QUARANTINE_LEVEL=1000.0 KILL_LEVEL=7.0 
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Subject: Absolute path inclusion in the FreeBSD Drivers.
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Sep 2006 07:45:20 -0000

Hi,

=20

I could see that all the file inclusion in all the driver use absolute
path. Can we use relative path and a CFLAG inclusion like this in the
Makefile?

=20

For example,

=20

In if_ixgb.h file,

#include <dev/ixgb/ixgb_hw.h>

#include <dev/ixgb/ixgb_ee.h>

#include <dev/ixgb/ixgb_ids.h>

=20

Instead can we have following lines in the
/usr/src/sys/modules/ixgb/Makfile file as

=20

.PATH: ${.CURDIR}/../../dev/ixgb

IXGB=3D   ${.CURDIR}/../../dev/ixgb

 CFLAGS+=3D -I. -I${IXGB}

=20

In if_ixgb.h file,

#include <ixgb_hw.h>

#include <ixgb_ee.h>

#include <ixgb_ids.h>

=20

Please advice.

=20

Thanks,

~Siva