From owner-svn-ports-head@FreeBSD.ORG Thu Aug 21 22:27:58 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED16A2FD; Thu, 21 Aug 2014 22:27:57 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C1A523EA6; Thu, 21 Aug 2014 22:27:57 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 8239D43BA5; Thu, 21 Aug 2014 17:27:38 -0500 (CDT) Message-ID: <53F6724A.6000602@marino.st> Date: Fri, 22 Aug 2014 00:27:22 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Bryan Drewery , marino@freebsd.org Subject: Re: svn commit: r365590 - in head/cad/spice: . files References: <201408211941.s7LJf6de048334@svn.freebsd.org> <53F663B2.3000800@marino.st> <20140822.070939.1253386656808735449.hrs@allbsd.org> <53F66EE5.7080500@FreeBSD.org> In-Reply-To: <53F66EE5.7080500@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Hiroki Sato , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2014 22:27:58 -0000 On 8/22/2014 00:12, Bryan Drewery wrote: > On 8/21/2014 5:09 PM, Hiroki Sato wrote: >> John Marino wrote >> in <53F663B2.3000800@marino.st>: >> >> fr> On 8/21/2014 21:41, Hiroki Sato wrote: >> fr> > Author: hrs >> fr> > Date: Thu Aug 21 19:41:06 2014 >> fr> > New Revision: 365590 >> fr> > URL: http://svnweb.freebsd.org/changeset/ports/365590 >> fr> > QAT: https://qat.redports.org/buildarchive/r365590/ >> >> ... >> >> fr> I'm sorry, but using freebsd-specific in a ports vendor >> fr> makefile is NOT an improvement and frankly puts the build at risk on >> fr> DragonFly. >> fr> >> fr> I wish there was a rule that ports should not use system make fragments. >> fr> This is not a good practice. This port had a perfectly working and >> fr> generic makefile before. >> fr> >> fr> There's a good chance this just broke spice on DragonFly as the system >> fr> make file these are different. >> >> I can understand that vendor's Makefile should be platform-neutral, >> but I do not think there is advantage to maintain >> ${FILESDIR}/Makefile in a way not to use FreeBSD-specific stuff >> because it is used only by the port. Should we care about build on >> DragonFly? > > No! This is FreeBSD. Ports is only officially supported on FreeBSD. > > There are plenty of other ports using bsd.prog.mk. Putting the first statement aside which frankly contradicts other statements made by other portmgr and completely belittles my contributions, this is a bad idea for FreeBSD too. You are not containing the port to ports collection. If the system makefile fragment changes, it affects the port. It's a dumb decision. If you want these makefile fragments, put a tailored copy of Mk/ In this PARTICULAR case, I staged the port. I fixed that makefile. HRS changes serve no purpose other than to potentially break my work. Obviously that is not his intention, but that is the result. Frankly he should revert this immediately. It was working before everywhere. John