From owner-svn-src-projects@FreeBSD.ORG Mon Dec 1 04:27:10 2014 Return-Path: <owner-svn-src-projects@FreeBSD.ORG> Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B8216AD; Mon, 1 Dec 2014 04:27:10 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42266182; Mon, 1 Dec 2014 04:27:10 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id rd3so10246694pab.7 for <multiple recipients>; Sun, 30 Nov 2014 20:27:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=cF6/wermR8pKROPFiE0rWFP1T22B9395xAW6vb6u/wY=; b=i/bMChk4r/8BgEiVKDV/OI73kjGaNGA8eE/NpkO4pTZjDkhQoeP2z7kwaTc1xM3rGc hWSE0O6sPD5GWL27QupKfREHQ/Vw5tQM941E54gkXyIDA8dxRiFpI4OSTQvbamzIAKfp ZHJ3dRIcd1kz7EYug/OSuCn36fKune4z15RvqH2tTovz9YG2ueu9PY0wieqdwjgYZKWu mzYAjRn4Ohk7w9HHO+I1kkMMrm3Pr3mI6nEFb5JiRfUSxWkJ2+2r+aHjuWqZ659zNDPP 5b4IBKBm+HzbWlu6TOXUGiRlibx1PD4SZotoms9Tmi+ygYaPz9fyhSMgndaUgjgh++Oy L42g== X-Received: by 10.66.228.72 with SMTP id sg8mr97062731pac.139.1417408029867; Sun, 30 Nov 2014 20:27:09 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:c83a:80c2:a7e8:2844? ([2601:8:ab80:7d6:c83a:80c2:a7e8:2844]) by mx.google.com with ESMTPSA id ht3sm16260624pad.18.2014.11.30.20.27.08 for <multiple recipients> (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 30 Nov 2014 20:27:09 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_B3082485-0599-454F-BA89-A36E7077B6EB"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r275219 - projects/building-blocks/share/skel From: Garrett Cooper <yaneurabeya@gmail.com> In-Reply-To: <20141130202521.GA1103@stack.nl> Date: Sun, 30 Nov 2014 20:27:07 -0800 Message-Id: <F4BC85AD-B1B0-477C-AA34-5FE67C7D173A@gmail.com> References: <201411282207.sASM7Gq7055794@svn.freebsd.org> <20141130202521.GA1103@stack.nl> To: Jilles Tjoelker <jilles@stack.nl> X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@FreeBSD.org> X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" <svn-src-projects.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/> List-Post: <mailto:svn-src-projects@freebsd.org> List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, <mailto:svn-src-projects-request@freebsd.org?subject=subscribe> X-List-Received-Date: Mon, 01 Dec 2014 04:27:10 -0000 --Apple-Mail=_B3082485-0599-454F-BA89-A36E7077B6EB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Nov 30, 2014, at 12:25, Jilles Tjoelker <jilles@stack.nl> wrote: > On Fri, Nov 28, 2014 at 10:07:16PM +0000, Garrett Cooper wrote: >> Author: ngie >> Date: Fri Nov 28 22:07:16 2014 >> New Revision: 275219 >> URL: https://svnweb.freebsd.org/changeset/base/275219 >=20 >> Log: >> Install skeleton files based on the values of MK_MAIL and MK_TCSH >=20 >> Customize according to MK_GAMES and MK_VI, in particular comment out = lines >> that would change behavior >=20 >> Change dot.cshrc and dot.profile to not check for /usr/games/fortune = based >> on the new behavior in customizing the files >=20 > Hmm, this assumes a rather specific use case: selecting a particular > combination of options, building everything and installing everything > what was built. >=20 > In particular, the run-time check for /usr/games/fortune was there > because a user might not install /usr/games, even though it was part = of > the built release. With "packaged base", this possibility will remain > important. Good point. What triggered this commit was something I noticed when I fixed =93MK_VI = =3D=3D no=94 to delete vi in base, which in turn breaks the default dot = files, i.e. 'export EDITOR=3Dvi=92. MK_VI =3D=3D no doesn=92t install vi = with installworld, but it doesn=92t clean it up on head if you run make = delete-old either, so this issue wasn=92t apparent until I started this = work (and I guess no one complained about the MK_VI =3D=3D no case = before now). To err on the safe side, I can add a `if [ -x /usr/bin/vi = ]; then ; fi` around the export EDITOR line if you like =97 however many = other OS distros (Fedora Linux, IllumOS, Ubuntu Linux, etc) don=92t ship = with defaults =97 is this something we should do as well? vi is also implicitly required for the build when building some files in = share/termcap, as the build calls ex on the files, but that=92s a = sidenote. > Also, dotfiles might be shared between systems by users. Yes, but shouldn=92t the person customizing the system know what files = are being distributed? > This is an objection against customizing dot.* file contents depending > on options, not against conditionally installing dot.* files. Ok. Something else that needs to be discussed is /usr/games being in = $PATH and a few other things, because this could slow down path lookups, = even if it=92s a small amount (I realize the namei cache is supposed to = make this less noticeable, but every little bit counts IMHO). Thanks for the input :)! --Apple-Mail=_B3082485-0599-454F-BA89-A36E7077B6EB Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJUe+4bAAoJEMZr5QU6S73eXQcH/1MJAAIDld3cu8FlalP/z6ZV HJmFNMOr3DOXHGLsX6ccjYZIpFVoSCGrD7A1RNsl5g2mY9uzAnvmqhZ07hF/yush MpHm51d2iNjvHPdOp3Wk8SP3Ng7gzQqTrKwP8mzg5m7NYitO9XKaodGq3xQO7ODr FqiQWsSFbSJJ3xS/1LZ9e3dJLK5ubLk4rqMfUepP+PEjqpAD5fpGVggIMB5cUXiC RAhC83JIxQkSR8OsjWZ9zK+gPTEqYlw6sehAPhqV5+WNFOK3zjHuYQBqsyZ3yk3r vryAXLossDpjs7djfbq/5Uo2JfwHrIK0WdM+/b9a4eJOHrE3CUp/ysJuRN3bL7o= =6o6n -----END PGP SIGNATURE----- --Apple-Mail=_B3082485-0599-454F-BA89-A36E7077B6EB--