From owner-freebsd-hackers@FreeBSD.ORG Fri Jan 7 23:25:07 2011 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0259C106566B for ; Fri, 7 Jan 2011 23:25:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id B26318FC16 for ; Fri, 7 Jan 2011 23:25:06 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 0FB0241C67B; Sat, 8 Jan 2011 00:25:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id elfcDFJwLKyj; Sat, 8 Jan 2011 00:25:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id A857441C64A; Sat, 8 Jan 2011 00:25:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 260304448F3; Fri, 7 Jan 2011 23:21:47 +0000 (UTC) Date: Fri, 7 Jan 2011 23:21:46 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: joris dedieu In-Reply-To: Message-ID: <20110107232016.S14966@maildrop.int.zabbadoz.net> References: X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-hackers Subject: Re: netinet6 little cleanup X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 23:25:07 -0000 On Fri, 7 Jan 2011, joris dedieu wrote: Hi, > As I was reading netinet6 code, I found some redundant SYSCTL_DECL. Why are the redundant currently? Scrolling though I am not seeing the "duplicate" removed. They are just distributed? > I don't know if it's really useful but here is a patch to clean it. > - remove SYSCTL_DECL(_net_inet6_ip6) and SYSCTL_DECL(_net_inet6) from c files > + add them to netinet6/in6_var.h header (like for netinet). Yeah, that's a different thing. /bz -- Bjoern A. Zeeb You have to have visions! Going to jail sucks -- All my daemons like it! http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html