From owner-svn-ports-head@freebsd.org  Thu Jan  5 15:03:00 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05042C9F04A;
 Thu,  5 Jan 2017 15:03:00 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id DD81B1AFE;
 Thu,  5 Jan 2017 15:02:59 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 3BD4A50FB; Thu,  5 Jan 2017 15:02:59 +0000 (UTC)
To: db@FreeBSD.org, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r430641 - in head/comms/wsjtx: . files
In-Reply-To: <201701051440.v05EeAs3029482@repo.freebsd.org>
Message-Id: <20170105150259.3BD4A50FB@freefall.freebsd.org>
Date: Thu,  5 Jan 2017 15:02:59 +0000 (UTC)
From: jbeich@freebsd.org (Jan Beich)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jan 2017 15:03:00 -0000

Diane Bruce <db@FreeBSD.org> writes:

> +		libomp.so:devel/openmp

devel/openmp is currently amd64-only, so comms/wsjtx loses i386 support
by unconditionally depending on it.

>  CMAKE_ARGS+=	-DPORT_BUILDING::STRING="ON" \
> -		-DCMAKE_PREFIX_PATH+=${LOCALBASE}/wsjtx/lib
> +		-DCMAKE_PREFIX_PATH+=${LOCALBASE}/wsjtx/lib \
> +		-DLOCALBASE::STRING="${LOCALBASE}"
[...]
> +if (CMAKE_SYSTEM_NAME STREQUAL "FreeBSD")
> +  set (FREEBSD TRUE)
> +  link_directories("/usr/lib" "${LOCALBASE}/lib")
> +  include_directories("/usr/lib" "${LOCALBASE}/include")
> +endif()

Why not add USES=localbase:ldflags instead? Besides, -I/usr/lib is bogus
while -L/usr/lib is poisonous for lang/gcc*.

> Modified: head/comms/wsjtx/distinfo
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-CMakeLists.txt
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-Radio.cpp
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-WFPalette.hpp
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/files/patch-manpages_CMakeLists.txt
> ==============================================================================
> Binary file (source and/or target). No diff available.
>
> Modified: head/comms/wsjtx/pkg-plist
> ==============================================================================
> Binary file (source and/or target). No diff available.

Can you fix svn:mime-type of these files?