From owner-p4-projects@FreeBSD.ORG  Wed Jan  2 17:05:15 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id F363116A419; Wed,  2 Jan 2008 17:05:14 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B909516A417
	for <perforce@freebsd.org>; Wed,  2 Jan 2008 17:05:14 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id A830A13C442
	for <perforce@freebsd.org>; Wed,  2 Jan 2008 17:05:14 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m02H5EoI050272
	for <perforce@freebsd.org>; Wed, 2 Jan 2008 17:05:14 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m02H5Ep9050265
	for perforce@freebsd.org; Wed, 2 Jan 2008 17:05:14 GMT
	(envelope-from jhb@freebsd.org)
Date: Wed, 2 Jan 2008 17:05:14 GMT
Message-Id: <200801021705.m02H5Ep9050265@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 132306 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jan 2008 17:05:15 -0000

http://perforce.freebsd.org/chv.cgi?CH=132306

Change 132306 by jhb@jhb_mutex on 2008/01/02 17:04:34

	Create a test mutex instead of abusing Giant and sched_lock.

Affected files ...

.. //depot/projects/smpng/sys/modules/crash3/crash3.c#2 edit

Differences ...

==== //depot/projects/smpng/sys/modules/crash3/crash3.c#2 (text+ko) ====

@@ -69,6 +69,7 @@
 #define	MAX_EVENT	event_max
 
 static int event_max;
+static struct mtx test1_mtx;
 static struct crash_event **event_start, **event_stop;
 
 static int	mod_event(struct module *module, int cmd, void *arg);
@@ -82,7 +83,9 @@
 ret_spin_mtx_locked(void)
 {
 
-	mtx_lock_spin(&sched_lock);
+	bzero(&test1_mtx, sizeof(test1_mtx));
+	mtx_init(&test1_mtx, "test1", NULL, MTX_SPIN);
+	mtx_lock_spin(&test1_mtx);
 }
 CRASH_EVENT("return with spin mutex locked", ret_spin_mtx_locked);
 
@@ -90,7 +93,9 @@
 ret_mtx_locked(void)
 {
 
-	mtx_lock(&Giant);
+	bzero(&test1_mtx, sizeof(test1_mtx));
+	mtx_init(&test1_mtx, "test1", NULL, MTX_DEF);
+	mtx_lock(&test1_mtx);
 }
 CRASH_EVENT("return with mutex locked", ret_mtx_locked);