From owner-svn-src-stable@freebsd.org Sat Feb 6 22:06:18 2016 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86650A9F249 for ; Sat, 6 Feb 2016 22:06:18 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x229.google.com (mail-wm0-x229.google.com [IPv6:2a00:1450:400c:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0CB3FC3C for ; Sat, 6 Feb 2016 22:06:17 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x229.google.com with SMTP id g62so89703528wme.0 for ; Sat, 06 Feb 2016 14:06:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=Am9S6Uv5jMNxIKFcDvCZ+/zd8FS5dOBBdL6mYr11R1Q=; b=z8fzgtNuzJAHio4rQMdzGKhlrYrbl7bOKqp0syxLc12Dlf9dSskck6mrqYvBFRoFAB Io3fAE7bK8U3Dx2b4rjhN7yQJk/957clwTRFKODQ/uEz9QNE9kft4XUFI9blWixokNnK IIFuBgtCINGUDonhjpXPtfndz+ExdD/grdlYFwZpcBpo3nDyvLqzGLZlx9lXsMbn7/Cd C/DmyvZxFOFGdqBGwU66uJqvOH2Aw9EDS/DQw5oWcauJhyKIU5gcFEClyypd/MmqYP0J AWDL+wKBKxjo0W0Z37OeONmJ+IwjV8K6i8maWPkd15sqmrYBUREg3lLuvFOOxToaJnJv b+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=Am9S6Uv5jMNxIKFcDvCZ+/zd8FS5dOBBdL6mYr11R1Q=; b=mvDROw/UXqoUOcnHt0w+vzTSqwhQONVBCqpFVaZaeGbtRGHzMg740i56cPFU/Xzwn2 WQIMStOgxYZc+ST9lBFz5+ny4Tu6TKrrkvJpYeB9erera+9Qw0r7sOeHaOe8mAq7GTes 7pzndHBSXH9ML2uwpHUNQghWFQ7AH3Q1JaNSvQuVOaGpz092XVlNjc+EAR+cCnN2uF1O aktOedzknwMTeoBTIh/3ELQOuF98HGfM+oXEwSyLFtJtWBNw7h1x4v9b1Yi6QtYLTcUT sZn2iSrpvqu9+cZXyM4N1TiGALi3jE4QNqgGNvFFkfJ4Gj48WzZm6hs3n8ZugaQD0XvW f5ug== X-Gm-Message-State: AG10YOQo4xuTFEOSIO7SASRQJnfeSm1MvylPpWiKoEgTd8Ke0VDphFF8Ufnh53k2/q9c9Kmb X-Received: by 10.28.148.130 with SMTP id w124mr4224091wmd.71.1454796376251; Sat, 06 Feb 2016 14:06:16 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id t205sm4972641wmt.23.2016.02.06.14.06.14 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 06 Feb 2016 14:06:14 -0800 (PST) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r294981 - in stable/10/sys/boot: common efi efi/boot1 efi/include efi/libefi efi/loader efi/loader/arch/amd64 fdt i386/libi386 To: NGie Cooper References: <201601281211.u0SCBhQG058154@repo.freebsd.org> <88C90200-1BC4-4C95-B37B-71AC33868217@gmail.com> Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org, FreeBSD Release Engineering Team Message-ID: <56B66E71.2050802@freebsd.org> Date: Sat, 6 Feb 2016 22:06:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <88C90200-1BC4-4C95-B37B-71AC33868217@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Feb 2016 22:06:18 -0000 After waiting 6 1/2 hours for a tinderbox build the fix for this is in r295356. I'm now kicking off a stable/10 tinderbox with this + ia64 (stable/10) fix. I'll know by tomorrow morning, apologies for the breakage. Regards Steve On 05/02/2016 21:22, NGie Cooper wrote: >> On Jan 28, 2016, at 04:11, Steven Hartland wrote: >> >> Author: smh >> Date: Thu Jan 28 12:11:42 2016 >> New Revision: 294981 >> URL: https://svnweb.freebsd.org/changeset/base/294981 >> >> Log: >> MFC r281169, r293724, r293796, r294029, r294041, r294058 >> >> MFC r281169 (by andrew): >> Make global variabled only used in this file static >> >> MFC r294058: >> Make common boot file_loadraw name parameter const >> >> MFC r294041: >> Remove unused reg param from fdt_fixup_memory >> >> MFC r293724: >> Enable warnings in EFI boot code >> >> MFC r293796: >> Fix typo in libefi.c >> >> MFC r294029: >> Only build EFI components on supported compilers >> >> Sponsored by: Multiplay > This commit broke tinderbox with arm:armeb on universe10a.freebsd.org: > > cc1: warnings being treated as errors > In file included from /scratch/tmp/ngie/svn/sys/boot/arm/uboot/../../common/load_elf32.c:7: > /scratch/tmp/ngie/svn/sys/boot/arm/uboot/../../common/load_elf.c: In function 'elf32_parse_modmetadata': > /scratch/tmp/ngie/svn/sys/boot/arm/uboot/../../common/load_elf.c:859: warning: cast to pointer from integer of different size > *** [load_elf32.o] Error code 1 > > Given the issues that we have with ia64 not being able to build right now, I would consider pulling this out of ^/stable/10, fully fixing it, then reintegrating it. > > Thanks, > -Ngie