From owner-freebsd-hackers Wed Oct 28 10:19:36 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA26174 for freebsd-hackers-outgoing; Wed, 28 Oct 1998 10:19:36 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from circe.bonn-online.com (circe.bonn-online.com [195.52.214.66]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id KAA26169 for ; Wed, 28 Oct 1998 10:19:34 -0800 (PST) (envelope-from lederer@bonn-online.com) Received: from bonn-online.com (ppp136.dialin.bonn-online.com [194.162.223.136]) by circe.bonn-online.com (8.8.5/8.8.5) with ESMTP id TAA14542; Wed, 28 Oct 1998 19:15:23 +0100 Message-ID: <36375F53.DBCC5CF5@bonn-online.com> Date: Wed, 28 Oct 1998 19:15:47 +0100 From: Sebastian Lederer X-Mailer: Mozilla 4.04 [en] (X11; I; FreeBSD 3.0-CURRENT i386) MIME-Version: 1.0 To: Studded , freebsd-hackers@FreeBSD.ORG Subject: Re: Patch for src/sys/i386/isa/wd.c References: <3634F865.9755D2E7@bonn-online.com> <3635180F.BA6C6F92@gorean.org> <3636067E.7C2249A3@bonn-online.com> <36362011.1235F2E1@gorean.org> <36362945.81950EC7@bonn-online.com> <36365603.3FCA1C60@gorean.org> Content-Type: multipart/mixed; boundary="------------1626A96235A1EC8778B655E1" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG This is a multi-part message in MIME format. --------------1626A96235A1EC8778B655E1 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Studded wrote: > Sebastian Lederer wrote: > > > Do you use 2.2-stable or 3.0-RELEASE ? > > -Stable. Sorry if I wasn't clear. > Digging around in the source code, I have found that the slice code only fakes a disklabel for the "whole disk slice", not for ordinary slices which have no label (yet). Given that, I rewrote the patch in a different way which is much less of a kludge and which should also work on -stable as on 3.0. Please test it, if you like. Best regards, Sebastian Lederer -- Sebastian Lederer lederer@bonn-online.com --------------1626A96235A1EC8778B655E1 Content-Type: text/plain; charset=us-ascii; name="wd.c.diff-current" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="wd.c.diff-current" *** sys/i386/isa/wd.c.orig Mon Oct 26 21:49:04 1998 --- sys/i386/isa/wd.c Wed Oct 28 18:47:06 1998 *************** *** 1330,1335 **** --- 1330,1341 ---- label.d_ncylinders = du->dk_dd.d_ncylinders; label.d_secpercyl = du->dk_dd.d_secpercyl; label.d_secperunit = du->dk_dd.d_secperunit; + + label.d_type = DTYPE_ESDI; + strcpy(label.d_typename,"fixed"); + bcopy(du->dk_params.wdp_model, label.d_packname, + sizeof(label.d_packname)); + error = dsopen("wd", dev, fmt, 0, &du->dk_slices, &label, wdstrategy1, (ds_setgeom_t *)NULL, &wd_cdevsw); } --------------1626A96235A1EC8778B655E1 Content-Type: text/plain; charset=us-ascii; name="wd.c.diff-stable" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="wd.c.diff-stable" *** wd.c.orig Wed Oct 28 19:09:41 1998 --- wd.c Wed Oct 28 19:05:50 1998 *************** *** 1196,1201 **** --- 1196,1207 ---- label.d_ncylinders = du->dk_dd.d_ncylinders; label.d_secpercyl = du->dk_dd.d_secpercyl; label.d_secperunit = du->dk_dd.d_secperunit; + + label.d_type = DTYPE_ESDI; + strcpy(label.d_typename,"fixed"); + bcopy(du->dk_params.wdp_model, label.d_packname, + sizeof(label.d_packname)); + error = dsopen("wd", dev, fmt, &du->dk_slices, &label, wdstrategy1, (ds_setgeom_t *)NULL, &wd_bdevsw, &wd_cdevsw); } --------------1626A96235A1EC8778B655E1-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message