From nobody Tue Feb 24 10:45:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fKvWD3mrCz6ThSq for ; Tue, 24 Feb 2026 10:45:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fKvWC5YMMz42mg for ; Tue, 24 Feb 2026 10:45:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771929911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eSJBB1E2QrSTH7Qvdb0RcdZvzUtTbIxrPwm+39SPStg=; b=yk4Rs06lh0L7ubfH2Wibr3V+GqW/Br1qjTlNNN/Xjuhf8+mCo8Q/dIKkyL+zL6L66VZ93U f14i8aCdBA5ljbdTyEH0QHKKaHKbc5Bm9Kgfv7xe9Iz8baX+DFvRUJpk13wxrdLpJuq/ny /Ud8Nnd+xk1F8PRqRowQ/iXp13rhwWIjKBW8yu6SAsVk1/ENhuHAvDJlow83mNR9YxPwad OR4QeIrt4gJGXhAaTVc7NkagCUl5exE7Wyep8ZX1KTU7eevJCGLWvBxC3wlfxBWmFg63dK RdARzmDfypa13syiTNRNfRYwDVvXe+pCWluEphT3ugj5ypYeZ3icts2SzF5X7Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771929911; a=rsa-sha256; cv=none; b=yTZCJ0HHxaO0dBQ2H7RlZPelZ4GFxv6t2faLEQfwO6F16zGLug8BCyn0I+RdbNixT+RPKN ZzMkgQm2BgCmT95sYEKCNWWS7K8zxCJcJyFccYfk9gCx29AHrkh7MGPKK8LBFcuc2JRq6f 6TxQYg21uveSNOgIL49IgFJNgWPvBnjdvs3pEpbeMo2xgCgdCBWeXLmjAiMfaYt+OK73CG b+6ptfNJ1bR8u7BBkErYYftiCCAyf6AHAYfWnn88qLZnIWb9/qkCvlv4ZRe/q4nwEx1lyo L0burHJDFsmTrvKyBsc4F++RrwzrACpAxlfWpuOuBAD8OW5OijN5L+Jh15kQiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771929911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eSJBB1E2QrSTH7Qvdb0RcdZvzUtTbIxrPwm+39SPStg=; b=LgU0EWIpGWYlByYNwPXeHt9asmJFa6eGGSrdhzvVu1IfxdwUFzfYyonxHIm8DeDPLTQLZ2 EnpPP52Ek2eevZue36mdtcwR/dUOQGHq2ziDgFcRCKMcCDUhZ8jlZzm8WdcYScuoSMJgb+ 70v0iR47KqzFfzrNBsX7iYCU4jtr7P/r+EFP+XJ1LbnhFw4weBWePczETID2dkqo5ZSCnn AS+KU9ws1kG9XMTFUejiRhf0y+nM+UQsu2ND94DW6la5BhCid+qkmQLbx7lTiGGqYI1Sga 8Io0P0Wt7TtZKrG926UapLD+xxlgQuvMWF1TZCRqYykMdp/upSqyAFkCnui0NQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fKvWC4b2lz1BK6 for ; Tue, 24 Feb 2026 10:45:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 337f7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 24 Feb 2026 10:45:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 52609ccbf703 - stable/13 - qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 52609ccbf7030f89133181ed5337f642b325f7af Auto-Submitted: auto-generated Date: Tue, 24 Feb 2026 10:45:11 +0000 Message-Id: <699d8137.337f7.4c6167b4@gitrepo.freebsd.org> The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=52609ccbf7030f89133181ed5337f642b325f7af commit 52609ccbf7030f89133181ed5337f642b325f7af Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:54 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-24 10:15:37 +0000 qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl Since the change [1], the init routine qlnx_init() works as intended. Let ether_ioctl() handle SIOCSIFADDR to simplify the code. Combined with the change [1], this shall be a better fix for PR 287445. [1] c10e6bc0f007 qlnxe: Avoid reinitializing the interface when it is already initialized PR: 287445 Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54888 (cherry picked from commit 4012b63889e40bb877bc0e4c8da1792bce472c08) (cherry picked from commit 0f383f74b7398161c12a290e50b060baf45d2800) (cherry picked from commit 20ffe22fcfe13b48a8e993cbf565f9cd9229a4b3) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 8bb599065f0c..cce23f0f7ea1 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2670,30 +2670,11 @@ qlnx_ioctl(struct ifnet *ifp, u_long cmd, caddr_t data) { int ret = 0, mask; struct ifreq *ifr = (struct ifreq *)data; - struct ifaddr *ifa = (struct ifaddr *)data; qlnx_host_t *ha; ha = (qlnx_host_t *)ifp->if_softc; switch (cmd) { - case SIOCSIFADDR: - QL_DPRINT4(ha, "SIOCSIFADDR (0x%lx)\n", cmd); - - if (ifa->ifa_addr->sa_family == AF_INET) { - ifp->if_flags |= IFF_UP; - QLNX_LOCK(ha); - if ((ifp->if_drv_flags & IFF_DRV_RUNNING) == 0) - qlnx_init_locked(ha); - QLNX_UNLOCK(ha); - QL_DPRINT4(ha, "SIOCSIFADDR (0x%lx) ipv4 [0x%08x]\n", - cmd, ntohl(IA_SIN(ifa)->sin_addr.s_addr)); - - arp_ifinit(ifp, ifa); - } else { - ether_ioctl(ifp, cmd, data); - } - break; - case SIOCSIFMTU: QL_DPRINT4(ha, "SIOCSIFMTU (0x%lx)\n", cmd);