From owner-freebsd-current@FreeBSD.ORG  Sun May 27 15:20:30 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1402616A4A0
	for <freebsd-current@freebsd.org>; Sun, 27 May 2007 15:20:30 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])
	by mx1.freebsd.org (Postfix) with ESMTP id EA69F13C483
	for <freebsd-current@freebsd.org>; Sun, 27 May 2007 15:20:29 +0000 (UTC)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu
	[127.0.0.1])
	by troutmask.apl.washington.edu (8.14.1/8.13.8) with ESMTP id
	l4RFIvTu075138; Sun, 27 May 2007 08:18:57 -0700 (PDT)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.14.1/8.13.8/Submit) id
	l4RFIeeo075082; Sun, 27 May 2007 08:18:40 -0700 (PDT)
	(envelope-from sgk)
Date: Sun, 27 May 2007 08:18:40 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Stefan Ehmann <shoesoft@gmx.net>
Message-ID: <20070527151840.GA73374@troutmask.apl.washington.edu>
References: <20070526193128.GB54875@troutmask.apl.washington.edu>
	<20070526190023.C98508@volatile.chemikals.org>
	<20070526233116.GA56054@troutmask.apl.washington.edu>
	<200705271053.10725.shoesoft@gmx.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200705271053.10725.shoesoft@gmx.net>
User-Agent: Mutt/1.4.2.2i
Cc: freebsd-current@freebsd.org, Ed Schouten <ed@fxq.nl>,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: HEADS-UP: gcc-4.2 import appears to miscompile libm.
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 May 2007 15:20:30 -0000

On Sun, May 27, 2007 at 10:53:09AM +0200, Stefan Ehmann wrote:
> On Sunday 27 May 2007 01:31:16 Steve Kargl wrote:
> > On Sat, May 26, 2007 at 07:09:16PM -0400, Wes Morgan wrote:
> > > Working from -O towards -O2 based on the info pages, I can "reproduce"
> > > the problem with "-O -fstrict-aliasing -fgcse"... However, -O2 with
> > > -fno-strict-aliasing by itself seems to work around the issue. At first
> > > glance it looks like a possible interaction between several
> > > optimizations.
> >
> > Ths patch fixes the problem.
> >
> > --- s_frexpf.c.orig     Sat May 26 16:26:50 2007
> > +++ s_frexpf.c  Sat May 26 16:28:03 2007
> > @@ -39,6 +39,9 @@
> >         }
> >         *eptr += (ix>>23)-126;
> >         hx = (hx&0x807fffff)|0x3f000000;
> > +#if 0
> >         *(int*)&x = hx;
> > +#endif
> > +       SET_FLOAT_WORD(x,hx);
> >         return x;
> >  }
> 
> -fno-strict-aliasing is used by default for me (i386). Also, if you use -Wall 
> the compiler outputs a warning.

You apparently don't have CFLAGS set in /etc/make.conf.

> [root@something /usr/src/lib/msun/src]# cc -O2 -Wall -pipe  -c s_frexpf.c
> s_frexpf.c: In function 'frexpf':
> s_frexpf.c:42: warning: dereferencing type-punned pointer will break 
> strict-aliasing rules

Yes, I know.

OTOH, the above patch actually fixes the problem, and libm can then
be compiled without -fno-strict-aliasing.

-- 
Steve