From owner-dev-commits-src-all@freebsd.org Fri Jan 8 22:38:13 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A79D24D8EC9; Fri, 8 Jan 2021 22:38:13 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCJ0P443bz3Np1; Fri, 8 Jan 2021 22:38:13 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x32c.google.com with SMTP id a6so8948572wmc.2; Fri, 08 Jan 2021 14:38:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=isw29QWebro5hRcmPl1RwBQX504+wDF7/QBZ5LU0/Hs=; b=APVaDHfNFqWg3KhqBkZhZ+EIPyPsTQSsQVFZNcwFwzHHfufgQS6Dy6fJky/76LRV2K Y0+oeHyFfc5S4q4VZjuiZWRr2KgpXEiBd1l/0yXATzGedZ8M2AddzXhCOp579XmoeeqV 1KdBGQV9XYLyq6ADcY7sYSb4BBJVcSKtPTcrNJVNq8mV2d85mDuvjz72itGKSCJOxaGu 9mY7SuCEIlFYtvgPMj+ehchq71xEp3lK+V+cViFf49g+Aw8RBKEGEbEaZPTHw/hzzAWX Z/VOunTnwJDrFMkM63PkdGAAj3AKKxTqhtuOveTwS2EKIv7CH5DpLXZ6PAN6qRrcdWQ4 r8uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=isw29QWebro5hRcmPl1RwBQX504+wDF7/QBZ5LU0/Hs=; b=lIaA1biQSZtLreafdRiFJmpzhbSdNfyRvQmSf3dep+f90EGrDyWZw6gq2O9HafnqGo DdKO4buLgOqwE9h1fgKU8zOjPLqS+HyZYCgSDsAGbuQgudYUYfYO0EeJ+fV53Gip0qqo gtEZLkwtIMPN63d1ce3RfWCUQFVDIwPJVXVD24uILp9ufS1GiXxHCQWDUuxMFWkbif6i njs+I9qgL0TLGnmj4J5aoq/ZCrKxpf54pedy9IvTNlGMenpLcTDkdbQeJRi47+y+9M7t uiyu38XLcQ4ZJmbHhpcYN3Wt95vsqvpPGwW1nh84IRK23mEGIDeG2OY2JLcUSwcZDr78 tIvg== X-Gm-Message-State: AOAM533SF+rLFgDwCSOnlnZlL63BnHguHO+j9A+bgQpoypybLb7h33pq t2Y3SCJopQlEK5Yy+9p4P8TBs1FDUmrI09d5HQflybdkuUc= X-Google-Smtp-Source: ABdhPJxvJe8Z+KAeSytDShaO8QInILg2RSN82NdOO2eZCC7dtn9IKpgTcwxNIsfIQyWUtGnpaMsZvt9dqoSOm8+3xC4= X-Received: by 2002:a7b:c773:: with SMTP id x19mr4757692wmk.127.1610145491621; Fri, 08 Jan 2021 14:38:11 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:f811:0:0:0:0:0 with HTTP; Fri, 8 Jan 2021 14:38:10 -0800 (PST) In-Reply-To: <252b68ff-3021-470f-3bc7-c6c809fa4958@FreeBSD.org> References: <202101072330.107NUM8u075841@gitrepo.freebsd.org> <252b68ff-3021-470f-3bc7-c6c809fa4958@FreeBSD.org> From: Mateusz Guzik Date: Fri, 8 Jan 2021 23:38:10 +0100 Message-ID: Subject: Re: git: 20ac5cda965e - main - fd: make fd/fp mandatory To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4DCJ0P443bz3Np1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 22:38:13 -0000 It definitely should have stated +/-: fd: make fd/fp mandatory in falloc I don't know how I dropped that part, it was reshuffled from a bigger patchset. On 1/8/21, John Baldwin wrote: > On 1/7/21 3:30 PM, Mateusz Guzik wrote: >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=20ac5cda965eccc34f975674c6efc97c3615a234 >> >> commit 20ac5cda965eccc34f975674c6efc97c3615a234 >> Author: Mateusz Guzik >> AuthorDate: 2020-12-23 13:50:34 +0000 >> Commit: Mateusz Guzik >> CommitDate: 2021-01-07 23:30:04 +0000 >> >> fd: make fd/fp mandatory >> >> They are both always passed anyway. > > Perhaps say which part of the API this affects (seems to be falloc*() from > the diff?) next time? As it reads now, the log implies it applies to all > functions in the file descriptor API which can't possibly be true (fdrop > doesn't take 'fd' for example). > > -- > John Baldwin > -- Mateusz Guzik