Date: Sat, 21 May 2016 20:36:43 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Adam Weinberger <adamw@adamw.org>, marino@freebsd.org, Ed Maste <emaste@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415078 - in head: . Mk Message-ID: <20160521183643.GL21899@ivaldir.etoilebsd.net> In-Reply-To: <20160521183507.GB96389@FreeBSD.org> References: <20160513201919.GA48945@FreeBSD.org> <CAPyFy2A9L1cCikOrgBAWUo0GTCLJ4EgzqukhobaJp%2BZqv7_SpQ@mail.gmail.com> <20160519122306.GA24015@FreeBSD.org> <20160521112728.GA624@FreeBSD.org> <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st> <20160521114358.GC624@FreeBSD.org> <20160521122522.GJ21899@ivaldir.etoilebsd.net> <20160521162931.GA97771@FreeBSD.org> <43145C09-EC33-4738-9FE7-5DC34A74D64B@adamw.org> <20160521183507.GB96389@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--9/GiYV45wF7IL3Iq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 21, 2016 at 06:35:07PM +0000, Alexey Dokuchaev wrote: > On Sat, May 21, 2016 at 11:11:12AM -0600, Adam Weinberger wrote: > > > On 21 May, 2016, at 10:29, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > > On Sat, May 21, 2016 at 02:25:22PM +0200, Baptiste Daroussin wrote: > > >> Implementing it as a Makefile variable would make it not automatical= ly > > >> updated. > > >=20 > > > Even if we can agree on REP_TIMESTAMP variable, why `make makesum' ca= nnot > > > sed -i the Makefile? > >=20 > > Oh god, please, no. Please do not mess with Makefiles. > >=20 > > Rather than having it come from 'makesum', can an svn hook write it to > > distinfo? May help it stay more current. >=20 > I understand your worries, but SVN already messes with Makefiles (keyword= s). > On the other hand, adding $Id$ to distinfo would both 1) solve the proble= m, > at least as I see it now, and 2) won't mix data with metadata which is I'm > debating against. >=20 > Baptiste, was adding $Id$ to distinfo considered/tested? If yes, why was= it > rejected? >=20 It won't work because keywords are not expanded in git and hg (and yes we do officially support our git mirror) Best regards, Bapt --9/GiYV45wF7IL3Iq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXQKq6AAoJEGOJi9zxtz5aD+0P/jLQcDi7oZSSbGEl9WZEf6Ra jX2V33bgUtZ2Vl+2eG817bzBkhEouhxER1timRPHNsdeVXBhZaOS08l2q96NTINa FNB2fWfRZnmlbuhHjaRAnM3vDc1ORMjDuL+hANgEywCcoOCQ+6+cb/I07Ee/r/xQ 7d2FJxihvnbcsslLBdL0bBxFoF/dMMADcUl3X31MTsv2nwGCp7cx7vgoi4EHWaiZ QCGVl/pimJDsftyVE+gEsiPQfcf5ZaxdZ1G8qUGlmZQpszH/AQDgp7MaxBBYYmkf KokW7rOoe0KwOzTcZEmsfVoog2DMLm/CXUpwvfSwNbxOWvxOCkoSU6QnmUXICOKU Ya5d9J41CQ3CNJZiC5P11RpAB4uDThZ5lJPzyP/7qDQ/ReW8kh2GyjHowXVE5j7q 1I35qqNiKtFsj9qQ3vdOR765rqO4IzzwN1GW0FP/HpsiWqWMxZ+icHR4CsxYfv3A 0eZHWMF7BE9G1BTkzwrRFq0iQ6Tb2VlA8XapI7WeLuhcJSt4HIw7gHyZh6bxua12 loQdPvGDyYGVt19oUdbiRlZ5SkBmfOn2i1H0eYqF9sJr6xDLQTG2CHJHuw5Ytoyw HSqeyLWuoqYKmCr01AQcMNpG90iNSRr+T6IeZuP8Ldb9C79PK4ynILqHWtCECL8Y cZPogd11n2LnStYnjBSc =3xFy -----END PGP SIGNATURE----- --9/GiYV45wF7IL3Iq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160521183643.GL21899>