Date: Mon, 22 Aug 2016 13:05:39 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209742] devel/godot: Update to 2.1; add devel/godot-tools port Message-ID: <bug-209742-13-smOz6ujC6I@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209742-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209742-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209742 lightside <lightside@gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173917|0 |1 is obsolete| | Attachment #173917|maintainer-approval?(FreeBS | Flags|D@ShaneWare.Biz) | Attachment #173937| |maintainer-approval?(FreeBS Flags| |D@ShaneWare.Biz) --- Comment #77 from lightside <lightside@gmx.com> --- Created attachment 173937 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173937&action= =3Dedit Proposed patch (since 415742 revision) (In reply to comment #76) > Using SLAVE_PORT was how I was told to do it in another port. This is right approach, in my opinion: https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D420461&view= =3Dmarkup#l1187 Even x11-servers/xorg-server port uses SLAVE_PORT checks: https://svnweb.freebsd.org/ports/head/x11-servers/xorg-server/Makefile?revi= sion=3D416966&view=3Dmarkup#l57 as many others: https://github.com/freebsd/freebsd-ports/search?q=3DSLAVE_PORT I agreed about SLAVE_PORT approach before, because value of PKGNAMESUFFIX variable may be changed to create a different package (with WITH_DEBUG=3Dye= s, for example): % make PKGNAMESUFFIX=3D-tools-debug -V PKGBASE godot-tools-debug Therefore, the value of PKGNAMESUFFIX variable is not quite useful for chec= ks here, in my opinion. (In reply to comment #76) > Use PORTEXAMPLES/EXAMPLESDIR Ok, I changed PORTDATA and DATADIR to PORTEXAMPLES and EXAMPLESDIR. But this may invalidate current user's paths for ${DATADIR}/demos projects. > PORTEXAMPLES=3D 2d 3d gui misc plugins viewport The README.md (including a reference to LICENSE.md file) maybe useful, in my opinion, while manual list of directories (instead of just *) may require to check them again for new version(s). > do-install-EXAMPLES-on: > @${ECHO} 'installing examples...' > .for d in ${PORTEXAMPLES} > @(cd ${WRKSRC_XMPL} && ${COPYTREE_SHARE} ${d} \ > ${STAGEDIR}${EXAMPLESDIR}) > .endfor The ${COPYTREE_SHARE} is a shell script, where first argument may be a list= of files/directories (i.e. "${PORTEXAMPLES}"): https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D420461&view= =3Dmarkup#l550 https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D420461&view= =3Dmarkup#l2153 No need to use a "for" loop here, in my opinion. > do-install: > @cd ${WRKSRC}/bin && ${INSTALL_SCRIPT} godot.x11* \ > ${STAGEDIR}/${PREFIX}/bin/${GODOTFILE} > ${STRIP_CMD} ${STAGEDIR}/${PREFIX}/bin/${GODOTFILE} The current usage of INSTALL_PROGRAM is right and not requires to strip a binary. (In reply to comment #76) > If after users on other systems build godot and need similar changes that > can share the same code then the test can be expanded or a more general t= est > can be put into place. I agree with this. The full support for DragonFlyBSD (or other operating system) may require to create a patches for other files, unrelated to this = PR. This might be a (Git) pull request for upstream from experienced people, wh= ich could test these changes on DragonFlyBSD, for example. While "alias" usage = in delta ports for devel/godot doesn't require to add patches for it (currentl= y): https://svnweb.freebsd.org/ports/head/Mk/Uses/alias.mk?revision=3D391257&vi= ew=3Dmarkup#l4 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209742-13-smOz6ujC6I>