From owner-svn-src-head@freebsd.org Mon Mar 11 19:52:54 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3B54152C71F; Mon, 11 Mar 2019 19:52:54 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id 352C9803F8; Mon, 11 Mar 2019 19:52:53 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 991545B63C; Mon, 11 Mar 2019 22:52:48 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id EgThp4iB6jQA; Mon, 11 Mar 2019 22:52:38 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id 9FBDF5B62C; Mon, 11 Mar 2019 22:52:38 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id B4ECD42211F; Mon, 11 Mar 2019 22:52:37 +0300 (MSK) X-Virus-Scanned: amavisd-new at cicgroup.ru Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id q-gEGQxsnLls; Mon, 11 Mar 2019 22:52:35 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTPA id F2CEC42211C; Mon, 11 Mar 2019 22:52:34 +0300 (MSK) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 11 Mar 2019 22:52:34 +0300 From: Vladimir Kondratyev To: Jung-uk Kim Cc: Ravi Pokala , Vladimir Kondratyev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344982 - head/sys/x86/isa In-Reply-To: References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> Message-ID: <8335f06543bd6f4d2119d74f7f4df74f@kondratyev.su> X-Sender: vladimir@kondratyev.su User-Agent: Roundcube Webmail/1.3.5 X-Rspamd-Queue-Id: 352C9803F8 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 19:52:55 -0000 On 2019-03-11 21:17, Jung-uk Kim wrote: > On 19. 3. 11., Ravi Pokala wrote: >> -----Original Message----- >> From: on behalf of Vladimir >> Kondratyev >> Date: 2019-03-10, Sunday at 13:19 >> To: , , >> >> Subject: svn commit: r344982 - head/sys/x86/isa >> >>> Author: wulf >>> Date: Sun Mar 10 20:19:43 2019 >>> New Revision: 344982 >>> URL: https://svnweb.freebsd.org/changeset/base/344982 >>> >>> Log: >>> atrtc(4): install ACPI RTC/CMOS operation region handler >> >> Hi Vladimir, >> >> This appears to have broken all the various LINT kernels for amd64 and >> i386: >> >> ================================================================ >> /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: >> error: use of undeclared identifier '_AcpiModuleName' >> ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:480:18: >> note: expanded from macro 'ACPI_FUNCTION_TRACE' >> AcpiUtTrace (ACPI_DEBUG_PARAMETERS) >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:402:39: >> note: expanded from macro 'ACPI_DEBUG_PARAMETERS' >> __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: >> error: use of undeclared identifier '_COMPONENT' >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:480:18: >> note: expanded from macro 'ACPI_FUNCTION_TRACE' >> AcpiUtTrace (ACPI_DEBUG_PARAMETERS) >> ^ >> /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/include/acoutput.h:402:56: >> note: expanded from macro 'ACPI_DEBUG_PARAMETERS' >> __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT >> ^ >> ================================================================ >> >> That same pattern of errors is noted for lines 321, 362, and 386. >> >> Please take a look at your earliest convenience. > > Please try the attached patch. > > Jung-uk Kim Thank you! It fixed LINT at least on amd64. Sorry for breakage :-( -- WBR Vladimir Kondratyev