From owner-freebsd-arm@freebsd.org  Wed Jul 15 13:58:36 2015
Return-Path: <owner-freebsd-arm@freebsd.org>
Delivered-To: freebsd-arm@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA3489A1B63
 for <freebsd-arm@mailman.ysv.freebsd.org>;
 Wed, 15 Jul 2015 13:58:36 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 by mx1.freebsd.org (Postfix) with ESMTP id 96EB912E0
 for <freebsd-arm@freebsd.org>; Wed, 15 Jul 2015 13:58:36 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.isc.freebsd.org (Postfix, from userid 1346)
 id 8A641E19E; Wed, 15 Jul 2015 13:58:36 +0000 (UTC)
Date: Wed, 15 Jul 2015 13:58:36 +0000
To: freebsd-arm@freebsd.org
From: "zbb (Zbigniew Bodek)" <phabric-noreply@FreeBSD.org>
Reply-to: D2378+327+81b4fa511783cd72@FreeBSD.org
Subject: [Differential] [Updated] D2378: Introduce ITS support for ARM64
Message-ID: <b87d79f5cdafa0cacd095f8ce40378ca@localhost.localdomain>
X-Priority: 3
Thread-Topic: D2378: Introduce ITS support for ARM64
X-Herald-Rules: <28>, <31>, <32>, <34>, <8>
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-yhwnadxnjthofqelhkdx>
X-Phabricator-To: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-To: <PHID-PROJ-qog24jek6izibfgj6dd6>
X-Phabricator-To: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-7dwczumdatyyxdjeiazl>
X-Phabricator-Cc: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-Cc: <PHID-USER-2wocyy2vsyzu2nddvuw6>
X-Phabricator-Cc: <PHID-USER-axkijn4pfdxlezgbnt7g>
X-Phabricator-Cc: <PHID-USER-pns6zgllnr6ze4h7ms3o>
X-Phabricator-Cc: <PHID-USER-wjsgsqx4il4yblud7x6c>
X-Phabricator-Cc: <PHID-USER-q5lmute3rwskeizvu5gf>
In-Reply-To: <differential-rev-PHID-DREV-xmqmcfafyun443233vly-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-xmqmcfafyun443233vly-req@FreeBSD.org>
Thread-Index: ZTc3NjU2YTNlNjQxNDIwYzYxMmJlZjFmYzJmIFWmZww=
Precedence: bulk
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 13:58:36 -0000

zbb marked 3 inline comments as done.

INLINE COMMENTS
  sys/arm64/arm64/gic_v3_fdt.c:199-200 FDT bindings. Removed comment in the commit.
  sys/arm64/arm64/gic_v3_fdt.c:280 There are two sets of probe/attach pairs here.
  sys/arm64/arm64/gic_v3_fdt.c:299 There are two sets of probe/attach pairs here. I think that this is not an unusual thing when we have attachments for two different drivers in the same file:
  
  /* Driver A */
  stuff_A;
  probe_A();
  attach_A();
  
  /* Driver B */
  stuff_B;
  probe_B();
  attach_B();
  
  They could be in a separate files but this is more convenient.
  sys/arm64/arm64/gic_v3_its.c:818 CPU writes to its cache while ITS has its own. We need this to stay coherent.
  sys/arm64/arm64/gic_v3_its.c:821 Everyone knows what barriers are for ...
  Is the necessity of detailed explanation of barriers usage limited only to ITS driver or other ARM64 code also has it? 
  sys/arm64/arm64/gic_v3_its.c:1077-1080 I will ask him.

REVISION DETAIL
  https://reviews.freebsd.org/D2378

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: zbb, imp, ian, emaste, manpages, andrew
Cc: eadler, gnn, kib, emaste, andrew, freebsd-arm-list, imp