From owner-cvs-all@FreeBSD.ORG  Sun Nov 30 06:11:19 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7B1D716A4CE; Sun, 30 Nov 2003 06:11:19 -0800 (PST)
Received: from arginine.spc.org (arginine.spc.org [195.206.69.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 42B7443FCB; Sun, 30 Nov 2003 06:11:18 -0800 (PST)
	(envelope-from bms@spc.org)
Received: from localhost (localhost [127.0.0.1])
	by arginine.spc.org (Postfix) with ESMTP
	id 598F4652FE; Sun, 30 Nov 2003 14:11:17 +0000 (GMT)
Received: from arginine.spc.org ([127.0.0.1])
 by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 10114-01; Sun, 30 Nov 2003 14:11:16 +0000 (GMT)
Received: from saboteur.dek.spc.org (unknown [82.147.19.91])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by arginine.spc.org (Postfix) with ESMTP
	id 858196520E; Sun, 30 Nov 2003 14:11:16 +0000 (GMT)
Received: by saboteur.dek.spc.org (Postfix, from userid 1001)
	id 66550C8; Sun, 30 Nov 2003 14:11:15 +0000 (GMT)
Date: Sun, 30 Nov 2003 14:11:15 +0000
From: Bruce M Simpson <bms@spc.org>
To: Jeff Roberson <jeff@FreeBSD.org>
Message-ID: <20031130141115.GA19707@saboteur.dek.spc.org>
Mail-Followup-To: Jeff Roberson <jeff@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200311300804.hAU84211002538@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200311300804.hAU84211002538@repoman.freebsd.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm uma_core.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Nov 2003 14:11:19 -0000

Jeff,

On Sun, Nov 30, 2003 at 12:04:01AM -0800, Jeff Roberson wrote:
>   Log:
>    - Replace the local maxcpu with mp_maxid.  Previously, if mp_maxid
>      was equal to MAXCPU, we would overrun the pcpu_mtx array because maxcpu
>      was calculated incorrectly.
>    - Add some more debugging code so that memory leaks at the time of
>      uma_zdestroy() are more easily diagnosed.

This change appears to break compilation of uniprocessor kernels. The
mp_maxid variable is defined in kern/subr_smp.c. In a uniprocessor kernel,
this symbol is undefined:-

kimchi:~/cvs/src/sys % nm /boot/kernel/kernel | grep mp_maxid
Exit 1

Regards,
BMS