Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 19 Aug 2017 10:43:07 +0000 (UTC)
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r448296 - in head/net/py-ldaptor: . files
Message-ID:  <201708191043.v7JAh7ng066079@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: koobs
Date: Sat Aug 19 10:43:06 2017
New Revision: 448296
URL: https://svnweb.freebsd.org/changeset/ports/448296

Log:
  net/py-ldaptor: Limit to 2.7 (Does not support Python 3.x)
  
  This port depends on Twisted, which supports Python 3.x as of a number of
  versions ago for some growing number of its components. On initial view, ldaptor
  appears inconsistent (at least not explicit) in its state of Python 3.x support
  for its latest version (16.0.0, not this ports version, 0.0.43)
  
  - A Python 3 compatible wheel is available on PyPI
  - Python 3.3-3.5 are included in tox.ini for testing
  
  However:
  
  - Travis CI configuration only tests with 2.7
  - Open "Python3 support #55" upstream issue [1]
  
  Additionally, Twisted/Python3 support aside, test builds (without USES=twisted
  declared), results in a build error at configure time:
  
    SyntaxError: invalid syntax
  
  This change limits build support to Python 2.7 accordingly.
  
  While I'm here:
  
  - Pet portlint: LICENSE [2], PLIST_FILES, makepatch.
  
  [1] https://github.com/twisted/ldaptor/issues/55
  [2] https://github.com/twisted/ldaptor/commit/7e249b1586789a5c588f662ce74ee9f4338666e0
  
  PR:		219323
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)
  MFH:		2017Q3

Deleted:
  head/net/py-ldaptor/pkg-plist
Modified:
  head/net/py-ldaptor/Makefile
  head/net/py-ldaptor/files/patch-setup.py

Modified: head/net/py-ldaptor/Makefile
==============================================================================
--- head/net/py-ldaptor/Makefile	Sat Aug 19 10:28:29 2017	(r448295)
+++ head/net/py-ldaptor/Makefile	Sat Aug 19 10:43:06 2017	(r448296)
@@ -12,15 +12,22 @@ DISTNAME=	ldaptor-${PORTVERSION}-${GITVERSION}
 MAINTAINER=	bra@fsn.hu
 COMMENT=	Pure-python LDAP module for Twisted
 
+LICENSE=	MIT LGPL21+
+LICENSE_COMB=	multi
+
 RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}pyparsing>=0:devel/py-pyparsing \
 		${PYTHON_PKGNAMEPREFIX}openssl>=0:security/py-openssl
 
 GITVERSION=	aad8ded658b36337a08aeb7402b6b67eb8771bea
 
 NO_ARCH=	yes
-USES=		gettext python twisted
+USES=		gettext python:2.7 twisted
 USE_PYTHON=	distutils autoplist
+
 PYDISTUTILS_INSTALL_TARGET=	install_locale install
 PYDISTUTILS_BUILD_TARGET=	build_locale build
+
+PLIST_FILES=	share/locale/fi/LC_MESSAGES/ldaptor-webui.mo \
+		share/locale/fr/LC_MESSAGES/ldaptor-webui.mo
 
 .include <bsd.port.mk>

Modified: head/net/py-ldaptor/files/patch-setup.py
==============================================================================
--- head/net/py-ldaptor/files/patch-setup.py	Sat Aug 19 10:28:29 2017	(r448295)
+++ head/net/py-ldaptor/files/patch-setup.py	Sat Aug 19 10:43:06 2017	(r448296)
@@ -1,6 +1,6 @@
---- setup.py.orig	2013-12-13 13:49:46.929425897 -0200
-+++ setup.py	2013-12-13 13:49:58.999423613 -0200
-@@ -154,7 +154,6 @@
+--- setup.py.orig	2011-06-10 07:02:47 UTC
++++ setup.py
+@@ -154,7 +154,6 @@ from the command line.
                      'build_locale': build_locale,
                      'clean': clean,
                      'clean_locale': clean_locale,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201708191043.v7JAh7ng066079>