From owner-freebsd-hackers Tue Jul 17 1:22:18 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from mailhub.fokus.gmd.de (mailhub.fokus.gmd.de [193.174.154.14]) by hub.freebsd.org (Postfix) with ESMTP id 537C537B403 for ; Tue, 17 Jul 2001 01:22:13 -0700 (PDT) (envelope-from brandt@fokus.gmd.de) Received: from beagle (beagle [193.175.132.100]) by mailhub.fokus.gmd.de (8.8.8/8.8.8) with ESMTP id KAA08234 for ; Tue, 17 Jul 2001 10:22:11 +0200 (MET DST) Date: Tue, 17 Jul 2001 10:22:11 +0200 (CEST) From: Harti Brandt To: Subject: Really simple patch... Message-ID: <20010717101638.V11504-100000@beagle.fokus.gmd.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Could please somebody make this little, trivial and obviuos patch, I requested it a while ago, or should I make a PR for it?? Hi, ()s are missing around the macro argument in cv_waitq_empty. The call if(!(cv_waitq_empty(&sc->foo_cv))) ... will otherwise fail to compile. harti Index: condvar.h =================================================================== RCS file: /usr/ncvs/src/sys/sys/condvar.h,v retrieving revision 1.2 diff -r1.2 condvar.h 66c66 < #define cv_waitq_empty(cvp) (TAILQ_EMPTY(&cvp->cv_waitq)) --- > #define cv_waitq_empty(cvp) (TAILQ_EMPTY(&(cvp)->cv_waitq)) -- harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.gmd.de, harti@begemot.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message