From owner-freebsd-usb@FreeBSD.ORG  Sun Nov  7 19:59:44 2004
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 598CA16A4CE
	for <freebsd-usb@freebsd.org>; Sun,  7 Nov 2004 19:59:44 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E19AC43D1D
	for <freebsd-usb@freebsd.org>; Sun,  7 Nov 2004 19:59:43 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (harmony.village.org [10.0.0.6])
	by harmony.village.org (8.13.1/8.13.1) with ESMTP id iA7JvqpN013497;
	Sun, 7 Nov 2004 12:57:52 -0700 (MST)
	(envelope-from imp@bsdimp.com)
Date: Sun, 07 Nov 2004 12:58:14 -0700 (MST)
Message-Id: <20041107.125814.34760598.imp@bsdimp.com>
To: rodrigc@crodrigues.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20041107064227.GA79915@crodrigues.org>
References: <20041107064227.GA79915@crodrigues.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: freebsd-usb@freebsd.org
Subject: Re: Changing permissions of /dev/usb[n] to 664?
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Nov 2004 19:59:44 -0000

In message: <20041107064227.GA79915@crodrigues.org>
            Craig Rodrigues <rodrigc@crodrigues.org> writes:
: Hi,
: 
: Is there any particular reason to leave the
: permissions of /dev/usb[n] at 660 instead of 664?
: 
: That would allow non-root users to run usbdevs
: to list the USB devices on the system.
: 
: 
: --- usb.c.orig	Sun Nov  7 01:41:43 2004
: +++ usb.c	Sun Nov  7 01:41:56 2004
: @@ -320,11 +320,11 @@
:  	/* The per controller devices (used for usb_discover) */
:  	/* XXX This is redundant now, but old usbd's will want it */
:  	sc->sc_usbdev = make_dev(&usb_cdevsw, device_get_unit(self), UID_ROOT,
: -	    GID_OPERATOR, 0660, "usb%d", device_get_unit(self));
: +	    GID_OPERATOR, 0664, "usb%d", device_get_unit(self));
:  	if (usb_ndevs++ == 0) {
:  		/* The device spitting out events */
:  		usb_dev = make_dev(&usb_cdevsw, USB_DEV_MINOR, UID_ROOT,
: -		    GID_OPERATOR, 0660, "usb");
: +		    GID_OPERATOR, 0664, "usb");
:  	}
:  #endif

This looks good, but we should audit all the ioctls to make sure the
ones that modify anything have the proper checks to make sure the fd
was opened for write.

Warner