From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 15:17:51 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 975BB166; Sun, 18 Nov 2012 15:17:51 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 5AB558FC0C; Sun, 18 Nov 2012 15:17:50 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id qAIFHWjf047169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 Nov 2012 00:17:42 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id qAIFHVsp016821; Mon, 19 Nov 2012 00:17:32 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 19 Nov 2012 00:17:26 +0900 (JST) Message-Id: <20121119.001726.1901703543569641080.hrs@allbsd.org> To: crees@FreeBSD.org Subject: Re: bin/165477: [rc] dhclient is run twice From: Hiroki Sato In-Reply-To: <201211181450.qAIEo0L7037418@freefall.freebsd.org> References: <201211181450.qAIEo0L7037418@freefall.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Nov_19_00_17_26_2012_329)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Mon, 19 Nov 2012 00:17:43 +0900 (JST) X-Spam-Status: No, score=-97.8 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,QENCPTR1,SAMEHELOBY2HOP,USER_IN_WHITELIST,X_CHINESE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 15:17:51 -0000 ----Security_Multipart(Mon_Nov_19_00_17_26_2012_329)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Chris Rees wrote in <201211181450.qAIEo0L7037418@freefall.freebsd.org>: cr> The following reply was made to PR bin/165477; it has been noted by GNATS. cr> cr> From: Chris Rees cr> To: Hiroki Sato cr> Cc: wblock@freebsd.org, "freebsd-rc@freebsd.org" , cr> "bug-followup@freebsd.org" cr> Subject: Re: bin/165477: [rc] dhclient is run twice cr> Date: Sun, 18 Nov 2012 14:40:00 +0000 cr> cr> On 17 November 2012 22:59, Hiroki Sato wrote: cr> > cr> > I think it is safe to remove the warning message when rc_quiet=YES. cr> > What do you think about the attached patch? cr> cr> I had originally considered that, but it then makes dhclient behave cr> differently from other scripts; nothing else respects rc_quiet in this cr> fashion; cr> cr> from rc.subr: cr> start) cr> if [ -z "$rc_fast" -a -n "$rc_pid" ]; then cr> echo 1>&2 "${name} already running? cr> (pid=$rc_pid)." cr> return 1 cr> fi cr> and cr> cr> [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart cr> musicpd already running? (pid=83847). I cannot understand why the dhclient script behaves differently from the others after patching rc.subr. Did you read the attached patch in my previous email? -- Hiroki ----Security_Multipart(Mon_Nov_19_00_17_26_2012_329)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCo/AYACgkQTyzT2CeTzy3TlgCg1zXTxAa4h1tVDH+Pe40U6AkM jdgAoLoeFv4i0d5Lg5FxgPDt3PLTSgRT =0LFr -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Nov_19_00_17_26_2012_329)----