From owner-cvs-src@FreeBSD.ORG  Wed Dec 20 14:25:37 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DDA4E16A5E2
	for <cvs-src@freebsd.org>; Wed, 20 Dec 2006 14:25:37 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C80F43CA5
	for <cvs-src@freebsd.org>; Wed, 20 Dec 2006 14:25:14 +0000 (GMT)
	(envelope-from asmrookie@gmail.com)
Received: by ug-out-1314.google.com with SMTP id o2so1942754uge
	for <cvs-src@freebsd.org>; Wed, 20 Dec 2006 06:25:13 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
	b=Vl7JUmbTuVd7pgl+C9dBHo15Gn3vN85BJkVyputACpoYVl64D3qTp1G/yh1AL5TGRqo6WYtufTLfzqf6ahGTBQ7Io4Lf86dnN4vPJzeYDe+BPFfLB7pBtg3c7vZs4iKznUO5foiy8dlxKF3Tv5kiLTs6L+PztZNzmejQkVPLqLc=
Received: by 10.82.153.5 with SMTP id a5mr1632730bue.1166624712651;
	Wed, 20 Dec 2006 06:25:12 -0800 (PST)
Received: by 10.82.178.4 with HTTP; Wed, 20 Dec 2006 06:25:12 -0800 (PST)
Message-ID: <3bbf2fe10612200625r527a7d2fj7319c9d6193c8816@mail.gmail.com>
Date: Wed, 20 Dec 2006 15:25:12 +0100
From: "Attilio Rao" <attilio@freebsd.org>
Sender: asmrookie@gmail.com
To: "Martin Blapp" <mb@imp.ch>
In-Reply-To: <20061220150622.V53548@godot.imp.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200612192234.kBJMYYo0055529@repoman.freebsd.org>
	<3bbf2fe10612191850y3a546fcew486575385b1400df@mail.gmail.com>
	<20061220120419.M53548@godot.imp.ch>
	<3bbf2fe10612200441i2f658b59i83de7c21c7290ab1@mail.gmail.com>
	<20061220150622.V53548@godot.imp.ch>
X-Google-Sender-Auth: 05db0150a04dca5f
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern tty.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Dec 2006 14:25:38 -0000

2006/12/20, Martin Blapp <mb@imp.ch>:
>
> Hi,
>
> > No, it drops Giant for all the time it sleeps.
> > Maybe the race is somewhere else.
>
> Yep, you are correct. It drops Giant for all the time.
>
> And during this time the session could be cleared
> somewhere else because we don't held GIANT anymore.
>
> I don't understand your problem ?

Quote:
"Log:
 Giant might have been temporarily dropped while waiting for
proctree_lock, allowing for an
 intervening tty_close() that cleared tp->t_session."

so, as you have seen, when a thread is waiting against proctree_lock
it doesn't held Giant. I don't understand the sense of your commit.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein