From owner-svn-ports-all@freebsd.org Fri Jul 13 13:59:13 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB8E8103D79F; Fri, 13 Jul 2018 13:59:13 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from ihor-3.amdmi3.ru (ihor-3.amdmi3.ru [185.117.152.228]) by mx1.freebsd.org (Postfix) with ESMTP id 5004B87192; Fri, 13 Jul 2018 13:59:13 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [127.0.0.1]) by ihor-3.amdmi3.ru (Postfix) with SMTP id C2F701AF123; Fri, 13 Jul 2018 16:59:05 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Fri, 13 Jul 2018 16:59:05 +0300 (MSK) Date: Fri, 13 Jul 2018 16:51:27 +0300 From: Dmitry Marakasov To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r474520 - head/x11-clocks/glclock Message-ID: <20180713135127.GK7353@hades.panopticon> References: <201807121411.w6CEBlZn074328@repo.freebsd.org> <1531464216.1955680.1439350032.7AC058F0@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1531464216.1955680.1439350032.7AC058F0@webmail.messagingengine.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 13:59:13 -0000 * Tobias Kortkamp (tobik@FreeBSD.org) wrote: > > Author: amdmi3 > > Date: Thu Jul 12 14:11:46 2018 > > New Revision: 474520 > > URL: https://svnweb.freebsd.org/changeset/ports/474520 > > > > Log: > > - Fix build with clang 6 > > > > Modified: > > head/x11-clocks/glclock/Makefile > > > > Modified: head/x11-clocks/glclock/Makefile > > ============================================================================== > > --- head/x11-clocks/glclock/Makefile Thu Jul 12 14:11:30 2018 (r474519) > > +++ head/x11-clocks/glclock/Makefile Thu Jul 12 14:11:46 2018 (r474520) > > @@ -15,6 +15,7 @@ USE_GL= gl glu glut > > MAKEFILE= makefile > > > > CFLAGS+= -DIMAGE_PATH="\\\"${PREFIX}/lib/X11/glclock/\\\"" > > +CXXFLAGS+= -Wno-c++11-narrowing > > Why is this needed after r474251? Was the previous fix not enough? It wasn't, I wasn't aware of your fix. > Besides that this breaks the build on Tier 2 archs like powerpc. > gcc 4.2 doesn't recognize -Wno-c++11-narrowing and treats it as an > error: > > cc1plus: error: unrecognized command line option "-Wno-c++11-narrowing" > > I think something like > > USES= compiler > CXXFLAGS+= ${CXXFLAGS_${CHOSEN_COMPILER_TYPE}} > CXXFLAGS_clang= -Wno-c++11-narrowing > > or similar would be better. This is too cumbersome. If it comes to this, this should be added to the framework as compiler:legacycode or something like that. But I really prefer for such fixes it to be in the Makefile and not a patch, as it makes the existence of rotten code more apparent, and makes garbage collecting either the fix (if the code is fixed upstream) or the whole port (as unmaintained legacy) easier. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: https://github.com/AMDmi3