From owner-cvs-src@FreeBSD.ORG Tue Aug 8 10:00:59 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9B9C16A4DE; Tue, 8 Aug 2006 10:00:59 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id A39B243D53; Tue, 8 Aug 2006 10:00:55 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k78A0o4M067445; Tue, 8 Aug 2006 14:00:51 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k78A0oHr067444; Tue, 8 Aug 2006 14:00:50 +0400 (MSD) (envelope-from yar) Date: Tue, 8 Aug 2006 14:00:50 +0400 From: Yar Tikhiy To: Gleb Smirnoff Message-ID: <20060808100050.GM54416@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <20060804095414.GU96644@FreeBSD.org> <20060804143825.GA8797@hub.freebsd.org> <20060804151422.GE96644@FreeBSD.org> <20060804162149.GB22299@hub.freebsd.org> <20060807114556.GC96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060807114556.GC96644@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Prafulla Deuskar , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2006 10:01:00 -0000 On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote: > > P> Is there a report on what coverty found with if_em_hw.c? > > Coverity complains that the return value of em_read_phy_reg() is > somtimes checked and sometimes is not. Can you please tell, whether > this is important report or can it be ignored? FWIW, a return value can be cast to (void) to tell explicitly that it doesn't matter. While ignoring a return value from a well-known function, such as close(), looks mostly OK to code readers (the author knows what he's doing, they think,) it may not be the case for a local function of limited application. -- Yar