From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jul 25 19:00:09 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCFA9106567F for ; Sat, 25 Jul 2009 19:00:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 599418FC28 for ; Sat, 25 Jul 2009 19:00:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n6PJ09HG093633 for ; Sat, 25 Jul 2009 19:00:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n6PJ09Oh093632; Sat, 25 Jul 2009 19:00:09 GMT (envelope-from gnats) Resent-Date: Sat, 25 Jul 2009 19:00:09 GMT Resent-Message-Id: <200907251900.n6PJ09Oh093632@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitrij Tejblum Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40687106566C for ; Sat, 25 Jul 2009 18:59:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 2D9C08FC08 for ; Sat, 25 Jul 2009 18:59:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n6PIxTxs094158 for ; Sat, 25 Jul 2009 18:59:29 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n6PIxTHP094157; Sat, 25 Jul 2009 18:59:29 GMT (envelope-from nobody) Message-Id: <200907251859.n6PIxTHP094157@www.freebsd.org> Date: Sat, 25 Jul 2009 18:59:29 GMT From: Dmitrij Tejblum To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/137136: [PATCH] Make python support in editor/gedit an explicit option X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2009 19:00:13 -0000 >Number: 137136 >Category: ports >Synopsis: [PATCH] Make python support in editor/gedit an explicit option >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jul 25 19:00:09 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Dmitrij Tejblum >Release: 7.2-RELEASE >Organization: >Environment: >Description: The editors/gedit port check if pygtksourceview is installed, and enable or disable support for python plugins depending on it. It is not very convenient for a newbie to install the port (without disabling any option!) and then discover that half of its features does not work for a non-obvious reason. Thus I suggest to convert it to an explicit OPTION. >How-To-Repeat: >Fix: Patch attached with submission follows: --- ports/editors/gedit/Makefile 2009-05-19 18:07:56.000000000 +0400 +++ ports/editors/gedit/Makefile 2009-07-25 22:46:30.000000000 +0400 @@ -41,9 +41,11 @@ WITH_GNOME= yes .endif -.include +OPTIONS= PYTHON "Enable Python Plugins" On -.if ${HAVE_GNOME:Mpygtksourceview}!="" +.include + +.ifdef WITH_PYTHON USE_PYTHON= yes .include "${PORTSDIR}/Mk/bsd.python.mk" USE_GNOME+= pygtksourceview @@ -63,4 +65,4 @@ post-install: @-update-desktop-database -.include +.include >Release-Note: >Audit-Trail: >Unformatted: