From owner-freebsd-current@freebsd.org Thu Jul 25 18:35:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9BB00AB369 for ; Thu, 25 Jul 2019 18:35:51 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C1578F694; Thu, 25 Jul 2019 18:35:51 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f194.google.com with SMTP id k18so48940541ljc.11; Thu, 25 Jul 2019 11:35:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qtWrMmbbZqQveEc13aKLlzUqRWoa4cXJQVU1hsIVRRs=; b=ql02i6cAvNGSb812qTBRn5mL4iXsEg92EA8SbNF5M1+SNb2lT4Wt+bFH5viu791uyJ Sp6KCOVXubmjpz787QLiFlVd0j3cuUJSP+fyxQ0OEp85kijzTy9Sgo9I9jBfnO0iZ57C YJX/lDyRHkcvNM0N8kuFmG4ac2ksmBC72eDeXzqocFFCUbotxKWpXV5M3+7d5WycIXW6 plXaJOwHT7+hvuGr92iVvS1/z9UWDF4B/WmR6oq3vNlYp75Zn0VwjhMA2EBJn5BT+EfH Latd6lpbZuehOH942st8rNBZwHrw6XEm6KbUYWd76HOpwCl3bA0IiWty9TnIcaBnpwGA AmTA== X-Gm-Message-State: APjAAAWN7F6jLX7YHF/B5oUnae0bbEBFb606eknCmW1EZPy8vN6HhzD/ c0R718VmyqxbBZ2HgWLxL6K+kZ3RaAoiwQZPMCM+Mw== X-Google-Smtp-Source: APXvYqx8/XSWacJl5/axQdxsK9hN60DcxEAxOG6j1tVPPAnbCHRdG0kb+TfyAShitDSip6kZLrBS8lpVaHTxqAbVig8= X-Received: by 2002:a2e:1290:: with SMTP id 16mr45168510ljs.88.1564079744017; Thu, 25 Jul 2019 11:35:44 -0700 (PDT) MIME-Version: 1.0 References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> In-Reply-To: From: Alan Somers Date: Thu, 25 Jul 2019 12:35:32 -0600 Message-ID: Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build To: Larry Rosenman Cc: Alan Somers , Freebsd current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4C1578F694 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 18:35:51 -0000 On Thu, Jul 25, 2019 at 12:13 PM Larry Rosenman wrote: > > On 07/25/2019 1:10 pm, Alan Somers wrote: > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman > > wrote: > >> > >> Um.... Who broke this? > >> > >> /usr/src/sys/sys/refcount.h:65:12: error: use of undeclared identifier > >> 'false' > >> return (false); > >> ^ > >> /usr/src/sys/sys/refcount.h:68:12: error: use of undeclared identifier > >> 'true' > >> return (true); > >> ^ > >> /usr/src/sys/sys/refcount.h:81:11: error: use of undeclared identifier > >> 'false' > >> return (false); > >> ^ > >> /usr/src/sys/sys/refcount.h:90:10: error: use of undeclared identifier > >> 'true' > >> return (true); > >> ^ > >> /usr/src/sys/sys/refcount.h:106:12: error: use of undeclared > >> identifier > >> 'false' > >> return (false); > >> ^ > >> /usr/src/sys/sys/refcount.h:108:12: error: use of undeclared > >> identifier > >> 'true' > >> return (true); > >> ^ > >> /usr/src/sys/sys/refcount.h:121:12: error: use of undeclared > >> identifier > >> 'false' > >> return (false); > >> ^ > >> /usr/src/sys/sys/refcount.h:123:12: error: use of undeclared > >> identifier > >> 'true' > >> return (true); > >> ^ > >> 8 errors generated. > >> *** Error code 1 > >> > >> Stop. > >> make[2]: stopped in > >> /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.93.2/lib > >> *** Error code 1 > >> > >> Stop. > >> make[1]: stopped in /wrkdirs/usr/ports/sysutils/lsof/work/lsof-4.93.2 > >> *** Error code 1 > >> > >> Stop. > >> make: stopped in /usr/ports/sysutils/lsof > >> > >> -- > >> Larry Rosenman http://people.freebsd.org/~ler > >> Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org > >> US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 > >> _______________________________________________ > >> freebsd-current@freebsd.org mailing list > >> https://lists.freebsd.org/mailman/listinfo/freebsd-current > >> To unsubscribe, send any mail to > >> "freebsd-current-unsubscribe@freebsd.org" > > > > > > "svn blame" suggests r350199 by kib. However, refcount.h should only > > be included if lsof defines _KERNEL, which normal programs shouldn't. > > So I think this should be considered a bug in lsof. > > -Alan > > > we *HAVE* to define _KERNEL, to get at the kernel structures..... Then I think you have to live with this amount of instability. refcount(9) says that you should include . Did you do that? If so, then this is a man page bug and refcount(9) should also specify stdbool.h. -Alan