From owner-svn-src-all@freebsd.org Mon Jun 3 14:10:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8789D15B20C7 for ; Mon, 3 Jun 2019 14:10:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 208B981EC5 for ; Mon, 3 Jun 2019 14:10:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x829.google.com with SMTP id i34so9473225qta.6 for ; Mon, 03 Jun 2019 07:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iwt3i3Gt0svCjH5TW40kp1/uE2umHkl+LtWx2EXZJEY=; b=ooT8ACe929p07rHhzN+sGE/SohZHIO3GsT1JxwlpXNaxNUt8o6LQyQVhvELISfIJYU 3xZoZJP5Z8yV37tRVZxrSdMWq6Ck3Ezv741dYbB6noaDWS89OiH/xyGrNbDYfg0xURwE v7z9EJI2P39SvWo8k++oJ0Bm7plTJTwCz+a3fN4aGRLFvCTKXVqi6jCElX9jGhasFWsR mHCHqle7n8j+Fs343qERUXE1pZauDRRMgCDmCRVYn9nzYq7T7c0gUBaq3Rr/sh1Zm3nq bfJiFDDV798urf8bKxa6rgWXmLwIKWfVudBfv0d+wie32bQ/ihS2f1I0y0pGwQsXhjef mwcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iwt3i3Gt0svCjH5TW40kp1/uE2umHkl+LtWx2EXZJEY=; b=qn0PsLLEl/O4AivK48Y2OAu4Wz2OvuU7/S429VIzYunea6glFqBB+cQywNXvsGetfz JBdF1zNCNVuryCdz2wPBd3YYuPR1VFQZ3pcj6Rxv5wwKVzCgphWsD9QzLuJTHG7vkAzK yzCBP++0kna/NXN8dI7ltb0QdU7iO9PvzDEO3rYDR6dhGG3C00K29P7g5TwmRioyZ3YQ s/maR7yOLW/hSoI/mo7tkswY7lUsgQUVEbdG8VXt+Z0oc/pWV0+BDCvWcEcz1qERJc58 uyOqkMaERHeT1iH8XLrXWYmx+RD/c5m5c4+TruSiT69nS8rjo6c4QAdXxixKPncRQt5m hl4w== X-Gm-Message-State: APjAAAURDpiaP+eqnpTFxR7YFirB/Eu/p1wMLg805ouKbv04Dw6aaA2k 4pBIc6ZFkU93YRCeGlUlI/4rq07GI/LYcVOGAvgung== X-Google-Smtp-Source: APXvYqylWHYmKKsl/SB5psrIIWMGly0yWWwFrABLBnZX2L/Xr4GKBGIRYoXyTqkqrPtMlnd6LvY94TLkEXHEl4uwVx0= X-Received: by 2002:a0c:b66f:: with SMTP id q47mr22109717qvf.102.1559571047194; Mon, 03 Jun 2019 07:10:47 -0700 (PDT) MIME-Version: 1.0 References: <201906031147.x53Blc0b013004@slippy.cwsent.com> <201906031354.x53DsV3X043188@gndrsh.dnsmgr.net> In-Reply-To: <201906031354.x53DsV3X043188@gndrsh.dnsmgr.net> From: Warner Losh Date: Mon, 3 Jun 2019 08:10:36 -0600 Message-ID: Subject: Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb To: "Rodney W. Grimes" Cc: Cy Schubert , Andrew Turner , Maxim Sobolev , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 208B981EC5 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.963,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 14:10:48 -0000 On Mon, Jun 3, 2019 at 7:54 AM Rodney W. Grimes wrote: > > In message <7BD6B7AD-5950-4015-B95D-9FFB609F51E9@fubar.geek.nz>, Andrew > Turner > > writes: > > > > > > > > > > On 3 Jun 2019, at 00:38, Maxim Sobolev wrote: > > > > > > > > Author: sobomax > > > > Date: Sun Jun 2 23:38:19 2019 > > > > New Revision: 348521 > > > > URL: https://svnweb.freebsd.org/changeset/base/348521 > > > > > > > > Log: > > > > Fix several places where tool name has been hardcoded: > > > > > > > > install -> ${INSTALL} > > > > mtree -> ${MTREE_CMD} > > > > services_mkdb -> ${SERVICES_MKDB_CMD} > > > > cap_mkdb -> ${CAP_MKDB_CMD} > > > > pwd_mkdb -> ${PWD_MKDB_CMD} > > > > kldxref -> ${KLDXREF_CMD} > > > > > > > > If you do custom FreeBSD builds you may want to override those > > > > in some cases. > > > > > > > > Sponsored by: Sippy Software, Inc. > > > > > > This breaks installworld in a local Jenkins instance. I???m building > with -DD > > > B_FROM_SRC and -DNO_ROOT. It looks like INSTALL is unset. > > > > > > Andrew > > > > > > -------------------------------------------------------------- > > > >>> Making hierarchy > > > -------------------------------------------------------------- > > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head; make -f > Makefile.inc1 > > > LOCAL_MTREE= hierarchy > > > cd /jenkins/workspace/FreeBSD-arm64-head/freebsd-head/etc; > PATH=/jenkins/work > ... > > > > It also breaks poudirere builds at make distrib-dirs, amd64 and i386, > i386 > > distrib-dirs on amd64 sample below. The src/etc/Makefile distrib-dirs > target > > is the failing one. > > Something is pretty broke here then, as INSTALL has been defined for > ever in sys.mk: > sys.mk:INSTALL ?= install > The problem is that MTREE isn't defined, which makes MTREE_CMD start with -N. Warner